Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom Hue BasicCluster in replacement #1813

Merged
merged 1 commit into from
Oct 8, 2022

Conversation

TheJulianJES
Copy link
Collaborator

@TheJulianJES TheJulianJES commented Oct 8, 2022

Small follow-up to #1812, as I forgot to push the second commit

Change: This actually uses the implemented BasicCluster, so the options for the trigger_indicator appear.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3212095609

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.0%

Totals Coverage Status
Change from base Build 3212084882: 0.0%
Covered Lines: 5944
Relevant Lines: 7430

💛 - Coveralls

@codecov-commenter
Copy link

Codecov Report

Base: 80.00% // Head: 80.00% // No change to project coverage 👍

Coverage data is based on head (9cd3bdc) compared to base (8f820d3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1813   +/-   ##
=======================================
  Coverage   80.00%   80.00%           
=======================================
  Files         239      239           
  Lines        7430     7430           
=======================================
  Hits         5944     5944           
  Misses       1486     1486           
Impacted Files Coverage Δ
zhaquirks/philips/motion.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dmulcahey dmulcahey merged commit 2292c4e into zigpy:dev Oct 8, 2022
@TheJulianJES TheJulianJES deleted the tjj/hue_use_basic_replacement branch January 25, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants