Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trigger LED attribute to Hue motion sensors #1812

Merged
merged 1 commit into from
Oct 8, 2022

Conversation

TheJulianJES
Copy link
Collaborator

@TheJulianJES TheJulianJES commented Oct 8, 2022

Tested and working on an indoor v2 SML003 Hue motion sensor.

Attribute reads as: Bool.false or Bool.true
Write attribute as: 0 or 1 (to disable or enable green trigger LED)

I'll also look at adding config entities for all Hue motion sensor options in HA Core itself.

required follow-up PR #1813 to use the cluster

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3212077261

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 80.0%

Totals Coverage Status
Change from base Build 3185142719: 0.01%
Covered Lines: 5944
Relevant Lines: 7430

💛 - Coveralls

@codecov-commenter
Copy link

Codecov Report

Base: 79.98% // Head: 80.00% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (fb0822e) compared to base (f13ba18).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1812      +/-   ##
==========================================
+ Coverage   79.98%   80.00%   +0.01%     
==========================================
  Files         239      239              
  Lines        7426     7430       +4     
==========================================
+ Hits         5940     5944       +4     
  Misses       1486     1486              
Impacted Files Coverage Δ
zhaquirks/philips/motion.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants