Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add primitive caching for Pooling forward computation #13

Merged
merged 1 commit into from
Jan 10, 2018

Conversation

TaoLv
Copy link

@TaoLv TaoLv commented Jan 10, 2018

Description

  1. Add primitive caching for Pooling forward computation;
  2. Enable Avg Pooling support
  3. Fix coding style
  4. Convergence is validated with cifar10 + ResNet50 (which has avg pooling layer).

Checklist

Essentials

  • Passed code style checking (make lint)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • For user-facing API changes, API doc string has been updated. For new C++ functions in header files, their functionalities and arguments are well-documented.
  • To my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@zheng-da zheng-da merged commit e814b3e into zheng-da:refactor Jan 10, 2018
@TaoLv TaoLv deleted the pooling-primitive branch January 18, 2018 09:50
zheng-da added a commit that referenced this pull request Jun 6, 2018
* remove SubgraphOperator.

* change the interface of SubgraphSelector.
zheng-da added a commit that referenced this pull request Jun 7, 2018
* remove SubgraphOperator.

* change the interface of SubgraphSelector.
zheng-da added a commit that referenced this pull request Jun 13, 2018
* remove SubgraphOperator.

* change the interface of SubgraphSelector.
TaoLv pushed a commit to TaoLv/incubator-mxnet that referenced this pull request Jun 16, 2018
* remove SubgraphOperator.

* change the interface of SubgraphSelector.
TaoLv pushed a commit to TaoLv/incubator-mxnet that referenced this pull request Aug 8, 2019
* Added tutorial for FIT API

* Added tests for Fit API tutorial

* Updated index.md for the new tutorial to show up

* Addressed PR feedback

* Addressed PR feedback

* Removed spurious comment for Py2 and Py3 compatibility

* Address PR feedback

* Addressed PR feedback

* Fixed typo

* Added example to showcase custom event handler

* Fixed imports as estimator moved to contrib package

* Added a side note to inform about estimator reference being updated by the handlers

* Corrected typo

* update tutorial

* address comments

* new line

* fix import

* fix cached graph

* fix import

* address comments

* fix doc gen

* add softmax

* add to website index

* fix doc string

* Fix doc gen (zheng-da#12)

* fix warining

* fix test

* fix

* fix

* fix print

* fix test (zheng-da#13)

* fix warning (zheng-da#14)

* fix href (zheng-da#15)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants