Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Querybook GitHub integration backend #2

Closed
wants to merge 1 commit into from

Conversation

zhangvi7
Copy link
Owner

@zhangvi7 zhangvi7 commented Oct 18, 2024

Context

Changes

  • Datasource endpoints:
    • Link datadoc to github
    • Commit/pushing datadoc
    • Retrieving all previous versions/commits of datadoc
    • Restoring a previous version of datadoc
  • GitHub Client
  • Serialize/Deserialize datadoc util (json)
  • Logic:
    • restore data_doc() - to persist restore previous version of datadoc
    • get and create_github_link()
  • DB:
    • Added new data model to store GitHub link - 1:1 mapping between datadoc and github {repo, branch, file_path}
  • Unit Tests
  • Updated requirements/extra.txt for pygithub

Test Plan

  • pytest querybook/tests/test_lib/test_github_integration/test_github_client.py
  • pytest querybook/tests/test_lib/test_github_integration/test_serializers.py
  • Manual E2E testing next PR

@zhangvi7 zhangvi7 changed the title feat: Querybook ithub integration backend feat: Querybook Gitub integration backend Oct 18, 2024
@zhangvi7 zhangvi7 changed the title feat: Querybook Gitub integration backend feat: Querybook GitHub integration backend Oct 18, 2024
@zhangvi7 zhangvi7 closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant