feat: Add oauth flow for querybook github integration #1497
Conversation
zhangvi7
force-pushed
the
github/oauth
branch
2 times, most recently
from
500a138
to
f0b1c90
Compare
zhangvi7
force-pushed
the
github/oauth
branch
from
f0b1c90
to
5a6db84
Compare
| return github_manager.github_integration_callback() | ||
|
|
||
|
|
||
| # Test GitHub OAuth Flow |
There was a problem hiding this comment.
let's not have the test code here. move to a separate test file
| def save_github_token(self, token: str) -> None: | ||
| flask_session["github_access_token"] = token | ||
| LOG.debug("Saved GitHub token to session") |
There was a problem hiding this comment.
will save to the user properties as well?
There was a problem hiding this comment.
Will handle refactoring to encrypt in db in later PR
| @flask_app.route(GITHUB_OAUTH_CALLBACK) | ||
| def github_callback() -> str: | ||
| github_manager = get_github_manager() | ||
| return github_manager.github_integration_callback() |
There was a problem hiding this comment.
would be better to just put this inside the datasources/github.py together with other github routes?
There was a problem hiding this comment.
I think we can leave here to keep OAuth flow logic together in GitHub manager, similar to gspread_exporter.py
| window.receiveChildMessage = receiveMessage; | ||
|
|
||
| // If the user closes the authentication window manually, clean up | ||
| const timer = setInterval(() => { |
There was a problem hiding this comment.
why it needs a timer here?
There was a problem hiding this comment.
detects if the user manually closed the authentication window to throw an error authentication process incomplete
| return config | ||
|
|
||
| def save_github_token(self, token: str) -> None: | ||
| flask_session["github_access_token"] = token |
There was a problem hiding this comment.
let's define a const for the key github_access_token as it will be used by other module
zhangvi7
force-pushed
the
github/oauth
branch
from
0ac6e33
to
27dbd01
Compare
feat: Add serializing util for datadoc github
feat: Link Datadoc to GitHub Directory
* feat: Add oauth flow for querybook github integration * link datadoc to github directory * feat: Add Datadoc serializing util
OAuth flow for querybook github integration feature
Test Plan
Datadoc rightside bar:
Modal:
GitHub Oauth:
Post OAuth Flow (To be changed):