During a peering from the hub side the hub will wait 30s or a spdy pi… #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng before the connection is considered timed out. When this happens it closes the underlying ./lib/web_socket.js which the ./lib/peer_client.js expects a error/close event to propagate back to the peer_client from the web_socket. In the case when the connection times out waiting for the http response from the websocket server in the cloud the error or close event never are emitted as the socket isn't estabiished yet and we do nothing here this.socket is not set from here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #358 by forcing a web_socket to emit close before it has the socket from the http response.