Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer reconnect fails if peer connection times out before http response is received #358

Closed
AdamMagaluk opened this issue Nov 1, 2017 · 0 comments · Fixed by #359
Closed
Labels

Comments

@AdamMagaluk
Copy link
Collaborator

During a peering from the hub side the hub will wait 30s or a spdy ping before the connection is considered timed out. When this happens it closes the underlying ./lib/web_socket.js which the ./lib/peer_client.js expects a error/close event to propagate back to the peer_client from the web_socket.

In the case when the connection times out waiting for the http response from the websocket server in the cloud the error or close event never are emitted as the socket isn't estabiished yet and we do nothing here this.socket is not set from here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant