stm32: xspi: Allow flash driver usage in RAM_LOAD mode #99729
+58
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following west manifest projects have changed revision in this Pull Request:
Additional metadata changed:
⛔ DNM label due to: 1 project with PR revision and 1 project with metadata changes Note: This message is automatically posted and updated by the Manifest GitHub Action. |
github-actions
bot
added
manifest
manifest-mcuboot
DNM (manifest)
erwango
force-pushed
the
fix_n6_flash_ext_app_upstream
branch
from
95dfb79 to
7eedd31
Compare
Instantiate a `soc-nv-flash` compatible node to allow using XSPI flash driver as a real flash controller on NOR device. Signed-off-by: Erwan Gouriou <[email protected]>
Current driver protections prevent to initialize driver when run as from an external application running from ext flash. Aim is to avoid performing full driver initialization of the NOR flash controller the application is read from. But this problem is actually only valid when application is running in XIP mode (read in memory mapped mode at run time). In ram load mode, since there is no direct activity from the application on the NOR device, nothing prevents the ext flash driver to be used fully. Hence, we should allow the controller initialization to happen, with some adjustments. Mostly, what we need is to: - skip the hal init - abort memory mapping afterwards to let the jedec reading happen. Remove conditions around `stm32_xspi_is_memorymap()` and `stm32_xspi_abort()` which can finally be useful in various cases. Signed-off-by: Erwan Gouriou <[email protected]>
Point upstream mcuboot PR fixing stm32n6 fsbl variant configuration Signed-off-by: Erwan Gouriou <[email protected]>
erwango
force-pushed
the
fix_n6_flash_ext_app_upstream
branch
from
7eedd31 to
5bab295
Compare
zephyrbot
added
area: Boards/SoCs
area: MCUBoot
area: Flash
platform: STM32
zephyrbot
requested review from
FRASTM,
GeorgeCGV,
d3zd3z,
de-nordic,
djiatsaf-st,
etienne-lms,
gautierg-st,
juickar,
mathieuchopstm,
nordicjm and
rghaddab
|
etienne-lms
reviewed
Nov 20, 2025
| } | ||
|
|
||
| #if defined(CONFIG_STM32_MEMMAP) || defined(CONFIG_STM32_APP_IN_EXT_FLASH) | ||
| #if defined(CONFIG_STM32_MEMMAP) || defined(CONFIG_STM32_APP_IN_EXT_FLASH) && defined(CONFIG_XIP) |
Contributor
There was a problem hiding this comment.
Could you add inner parentheses to prevent from confusion?
Suggested change
| #if defined(CONFIG_STM32_MEMMAP) || defined(CONFIG_STM32_APP_IN_EXT_FLASH) && defined(CONFIG_XIP) | |
| #if defined(CONFIG_STM32_MEMMAP) || (defined(CONFIG_STM32_APP_IN_EXT_FLASH) && defined(CONFIG_XIP)) |
Could you update the #endif counter part?
| } | ||
|
|
||
| #ifdef CONFIG_STM32_APP_IN_EXT_FLASH | ||
| #if defined(CONFIG_STM32_APP_IN_EXT_FLASH) && defined(CONFIG_XIP) |
Contributor
There was a problem hiding this comment.
Could you update the #endif counter part?
| /* If needed by the application, it will be re-enabled just after */ | ||
| ret = stm32_xspi_abort(dev); | ||
| if (ret != 0) { | ||
| LOG_ERR("Failed to abort memory-mapped access before init"); |
Contributor
There was a problem hiding this comment.
Is it safe to continue the function execution? It seems to me this should return with an error code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, STM32 XSPI flash driver initialization aborts if application is run from external flash.
Though, constraints are actually different if:
Fix XSPI driver to allow flash operations in RAM LOAD.
Make necessary changes on N6 DK to be able to make use of it.
Once approved, it will have to be extended to O/QSPI drivers.
Then, we should also make sure this work using MSPI drivers.
Edit: Depends on mcu-tools/mcuboot#2547