drivers: firmware: Clock control TISCI driver support#90216
Conversation
7cf310e to
2dc18ee
Compare
8b10b9f to
9ee64d7
Compare
9a47dbf to
20b38b7
Compare
6bd0da6 to
7f1f9bf
Compare
2154640 to
20a6a86
Compare
JarmouniA
left a comment
There was a problem hiding this comment.
Should be enabled on at least one board in-tree and be tested with an existing or a new testsuite.
|
@Kronosblaster It looks
@Kronosblaster , it looks like #91914 has build errors, how was this tested? and how do we ensure that this is not merged in a broken state? |
When there is serial dependency between PRs, to ensure we are not merging stuff that doesn't even compile, you should do: For PRs A, B, & C, where C depends on B, B depends on A, and assuming C contains the actual tests that will validate all the code in the 3 PRs, |
As @JarmouniA mentioned the PR #91914 has be converted to a draft with this PR added so as to enable testing |
|
Adding DNM until testing is done |
#91914 shows errors unrelated to the PR |
|
@Kronosblaster I don't see #91914 enabling any tests that will cover the added code here & there. Are there already test scenarios in-tree that cover it? |
The TISCI clock control framework only frames and wraps TISCI API calls which have in-tree tests. A similar implementation would be the SCMI clock controller framework which does not have specific tests for clock layer either. |
|
The failing twister test should be fixed by this #98388. Ergo, this patchset can be merged. |
@JarmouniA Can this be merged? |
Support added for clock control using TISCI for devices using the binding ti,k2g-sci-clk. This driver relies on the TISCI layer to make calls to the DMSC core to set and get the clock rate and retrieve clock status. Signed-off-by: Dave Joseph <d-joseph@ti.com>
edca610
86fd461 to
edca610
Compare
|



Support added for clock control using TISCI added for devices using the binding ti,k2g-sci-clk. This PR waits on #90053
Testing
Refer: ClockControllerTest
Output: