drivers: firmware: TISCI driver support#90053
Conversation
Kronosblaster
force-pushed
the
tisciLayer
branch
11 times, most recently
from
57339a6 to
cf7f4fb
Compare
|
@Kronosblaster Please provide proper commit message/details to help a reviewer to understand what this is. |
Kronosblaster
force-pushed
the
tisciLayer
branch
2 times, most recently
from
11a1071 to
8202cff
Compare
Kronosblaster
force-pushed
the
tisciLayer
branch
2 times, most recently
from
2b4ddf5 to
176711d
Compare
github-actions
Bot
added
the
platform: TI SimpleLink
Now that the platform support is upstream, can a proper test and the DT changes for tisci node be made part of this PR? |
glneo
left a comment
glneo
left a comment
There was a problem hiding this comment.
There are some minor things I'd still like to cleanup here, but they can be handled in later PRs, this one has had enough nitpicking from me :).
For now this all looks good enough to start.
|
|
||
| dmsc: system-controller@44043000 { | ||
| compatible = "ti,k2g-sci"; | ||
| ti,host-id = <36>; |
There was a problem hiding this comment.
Linux says 12 for in k3-am64x-main.dtsi
There was a problem hiding this comment.
TISCI host IDs
Linux runs on A53 cores. This is for the R5 core 0 context 1.
There was a problem hiding this comment.
If this changes for each core, then why is this in the common DTSI file? This number should go in the R5 core 0 specific files. Same for secure_proxy_main mboxes and IRQs.
There was a problem hiding this comment.
I agree with @glneo - this value should not be in this file as it can be used by the A53 and R5. Totally fine to change that later.
This change modifies the secure proxy mailbox driver to pass user data to the interrupt service routine (ISR) callback. This allows the ISR to access the specific context or data associated with the mailbox message being processed. Signed-off-by: Dave Joseph <d-joseph@ti.com>
Added TISCI driver for supported devices using the binding ti,k2g-sci. This is used to communicate via the secury proxy channel for clock, resource and power domain management. Refer: https://software-dl.ti.com/tisci/esd/latest/2_tisci_msgs/general/TISCI_header.html Signed-off-by: Dave Joseph <d-joseph@ti.com>
Device tree edits to add DMSC system controller support for AM2434 EVM. This includes the addition system-controller and secure-proxy mailbox nodes in arm46x_main.dtsi. Signed-off-by: Dave Joseph <d-joseph@ti.com>
TISCI driver test added to validate the TISCI API functionality in Zephyr. This test is for the target am243x_evm/am2434/r5f0_0. Signed-off-by: Dave Joseph <d-joseph@ti.com>
|
| { | ||
| struct tisci_data *data = dev->data; | ||
|
|
||
| k_sem_take(&data->data_sem, K_FOREVER); |
There was a problem hiding this comment.
If there is no response requested or an error occurs then this semaphore needs to be released
It might be a good idea to reset the response sem here too (k_sem_reset()). It could help recover if a previous request fails or times out
8 participants
Fixed bugs in secureproxy mailbox driver
Added TISCI driver for supported devices using the binding ti,k2g-sci.
Added TISCI AM2434 EVM
Added TISCI test sample
API test:
The test sample is present at /tests/drivers/tisci
Test Sequence
Version Information
Clock Management
Power Domain Control
tisci_cmd_get_devicetisci_cmd_put_deviceTISCI documentation of messages is given here