drivers: usb: udc: Added check for NULL ep_cfg#106846
Closed
stites-infineon wants to merge 1 commit intozephyrproject-rtos:mainfrom
Closed
drivers: usb: udc: Added check for NULL ep_cfg#106846stites-infineon wants to merge 1 commit intozephyrproject-rtos:mainfrom
stites-infineon wants to merge 1 commit intozephyrproject-rtos:mainfrom
Conversation
This driver assumes endpoints are always initialized. The testusb sample was only using and initializing some, causing the remaining ones to remain NULL, leading to a fault. Added NULL checks prior to dereferencing these, plus logging. Signed-off-by: Zayne Stites <Zayne.Stites@infineon.com>
|
jfischer-no
requested changes
Apr 7, 2026
Comment on lines
+839
to
+843
| if (cfg == NULL) { | ||
| LOG_ERR("No ep_cfg for DOUT event"); | ||
| return -ENODEV; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
This driver assumes endpoints are always initialized.
They should be, there must be something else wrong with your quirks/porting.
Contributor
Author
There was a problem hiding this comment.
Ah okay, thank you for clarifying. I'll debug my device support update then to see why they aren't. Closing this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This driver assumes endpoints are always initialized. Added NULL checks prior to dereferencing these, plus logging.
See #106845