Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix races #9

Merged
merged 2 commits into from
Jan 18, 2023
Merged

fix races #9

merged 2 commits into from
Jan 18, 2023

Conversation

tomkukral
Copy link
Contributor

fix test races

closes #8

@tomkukral
Copy link
Contributor Author

@zenthangplus please review

goccm.go Outdated Show resolved Hide resolved
@tomkukral
Copy link
Contributor Author

@zenthangplus updated according to your comments, please review again

@zenthangplus
Copy link
Owner

@zenthangplus updated according to your comments, please review again

@tomkukral test failed, please check

@tomkukral
Copy link
Contributor Author

It is failing on golang 1.10 (released in 2018) and this legacy version doesn't support formating I was using.

There are two options:

  • A - stop testing on golang 1.10
  • B - update code to be compatible with 1.10

I'd prefer A because 1.10 is very old and many projects have already migrated to newer version. My my suggestion is remove 1.10 from tests and add 1.19. Do you agrees @zenthangplus ?

@zenthangplus
Copy link
Owner

It is failing on golang 1.10 (released in 2018) and this legacy version doesn't support formating I was using.

There are two options:

  • A - stop testing on golang 1.10
  • B - update code to be compatible with 1.10

I'd prefer A because 1.10 is very old and many projects have already migrated to newer version. My my suggestion is remove 1.10 from tests and add 1.19. Do you agrees @zenthangplus ?

@tomkukral i think it not related to v1.10, because you are printed chan int32 as integer type. could you help to fix it?
https://github.com/zenthangplus/goccm/pull/9/files#diff-37ca082752c510e847f4d76524b6c582371b834c2007b6bdf17316454eea9c1aR69

fix test races

closes zenthangplus#8
@tomkukral
Copy link
Contributor Author

@zenthangplus you are right, it can change type before printing it. Fixed.

@zenthangplus zenthangplus merged commit 2ccf719 into zenthangplus:master Jan 18, 2023
@zenthangplus
Copy link
Owner

Thank @tomkukral, it was merged

@tomkukral
Copy link
Contributor Author

Btw, I have implemented very similar logic in my tool. I wanted to get possiblity to limit waiting time and abort waiting. You can check it and use it in this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple race conditions
2 participants