-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix races #9
fix races #9
Conversation
@zenthangplus please review |
@zenthangplus updated according to your comments, please review again |
@tomkukral test failed, please check |
It is failing on golang 1.10 (released in 2018) and this legacy version doesn't support formating I was using. There are two options:
I'd prefer A because 1.10 is very old and many projects have already migrated to newer version. My my suggestion is remove 1.10 from tests and add 1.19. Do you agrees @zenthangplus ? |
@tomkukral i think it not related to v1.10, because you are printed |
fix test races closes zenthangplus#8
@zenthangplus you are right, it can change type before printing it. Fixed. |
Thank @tomkukral, it was merged |
Btw, I have implemented very similar logic in my tool. I wanted to get possiblity to limit waiting time and abort waiting. You can check it and use it in this library. |
fix test races
closes #8