avoid race conditions and add a method to prevent channel leakage #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Release Closes all the channels associated with goccm | ||
| func (c *concurrencyManager) Release() { | ||
| close(c.managerCh) |
There was a problem hiding this comment.
Why not close channels in Close() method?
There was a problem hiding this comment.
First it was there and I also think that it is more natural. But I think you expect to call the close twice from this test:
https://github.com/zenthangplus/goccm/blob/master/goccm_test.go#L22
zenthangplus
reviewed
Jan 5, 2023
goccm.go
Outdated
| @@ -35,7 +40,7 @@ type ( | |||
| allDoneCh chan bool | |||
|
|
|||
| // The close flag allows we know when we can close the manager | |||
| closed bool | |||
| closed atomic.Bool | |||
There was a problem hiding this comment.
atomic.Bool is only available since Go 1.19. Also, other contributor presented another solution using channel. Could you take a look: #9
There was a problem hiding this comment.
just fixed it another commit.
|
@mehdipourfar This issue has been fix in this MR #9, please take a look |
|
I've looked at it. But it seems too complex for checking a simple flag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.