Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(focusvisible): migrate focusvisible to TypeScript #137

Merged
merged 1 commit into from
Nov 14, 2019
Merged

feat(focusvisible): migrate focusvisible to TypeScript #137

merged 1 commit into from
Nov 14, 2019

Conversation

hzhu
Copy link
Contributor

@hzhu hzhu commented Nov 13, 2019 •
edited
Loading

Description

This pull request migrates the focusvisible package to TypeScript.

Checklist

  • 🌐 Storybook demo is up-to-date (yarn start)
  • ♿ analyzed via axe and evaluated using VoiceOver
  • 💂‍♂️ includes new unit tests
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

@hzhu hzhu changed the title feat(focusvisible): migrate focusvisible to TypeScript 🚧feat(focusvisible): migrate focusvisible to TypeScript Nov 13, 2019
@hzhu hzhu changed the title 🚧feat(focusvisible): migrate focusvisible to TypeScript feat(focusvisible): migrate focusvisible to TypeScript Nov 13, 2019
austingreendev
austingreendev reviewed Nov 13, 2019
View reviewed changes
packages/focusvisible/src/index.ts Outdated Show resolved Hide resolved
packages/focusvisible/src/useFocusVisible.ts Outdated Show resolved Hide resolved
packages/focusvisible/stories.tsx Outdated Show resolved Hide resolved
hzhu
hzhu commented Nov 13, 2019
View reviewed changes
package.json Outdated Show resolved Hide resolved
packages/focusvisible/src/FocusVisibleContainer.spec.tsx Show resolved Hide resolved
packages/focusvisible/src/useFocusVisible.ts Show resolved Hide resolved
@hzhu hzhu force-pushed the hzhu/focusvisible-typescript branch from e8866b4 to f592ac3 Compare November 14, 2019 00:24
@hzhu hzhu marked this pull request as ready for review November 14, 2019 03:20
@hzhu hzhu requested a review from a team as a code owner November 14, 2019 03:20
austingreendev
austingreendev approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@austingreendev austingreendev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides the small comments

packages/focusvisible/src/FocusVisibleContainer.spec.tsx Show resolved Hide resolved
packages/focusvisible/stories.tsx Show resolved Hide resolved
@hzhu hzhu force-pushed the hzhu/focusvisible-typescript branch from 9152bac to e83274e Compare November 14, 2019 17:53
@hzhu hzhu self-assigned this Nov 14, 2019
@hzhu hzhu force-pushed the hzhu/focusvisible-typescript branch from 8a7653c to 52a1447 Compare November 14, 2019 18:57
@hzhu hzhu merged commit 335357a into master Nov 14, 2019
@hzhu hzhu deleted the hzhu/focusvisible-typescript branch November 14, 2019 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzempel jzempel jzempel approved these changes

@austingreendev austingreendev austingreendev approved these changes

Assignees

@hzhu hzhu

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hzhu @jzempel @austingreendev