Skip to content

Commit

Permalink
Code review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
hzhu committed Nov 13, 2019
1 parent 696633a commit e8866b4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion packages/focusvisible/src/useFocusVisible.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export const INPUT_TYPES_WHITE_LIST: Record<string, boolean> = {
};

export interface IUseFocusVisibleProps {
scope?: React.RefObject<HTMLElement | undefined>;
scope?: React.RefObject<HTMLElement | null>;
relativeDocument?: any;
className?: string;
dataAttribute?: string;
Expand Down
4 changes: 2 additions & 2 deletions packages/focusvisible/stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,15 @@ interface IStyledCustomFocus extends React.HTMLProps<HTMLDivElement> {
isSelected?: boolean;
}

const StyledCustomFocus = styled.div`
const StyledCustomFocus = styled.div<IStyledCustomFocus>`
:focus {
outline: none;
}
&[data-garden-focus-visible] {
outline: 2px dashed red;
}
` as React.FC<IStyledCustomFocus>;
`;

const StyledWrapper = styled.div`
* {
Expand Down

0 comments on commit e8866b4

Please sign in to comment.