fix: Widen Array to Array | ChunkedArray#181
Merged
zen-xu merged 6 commits intozen-xu:mainfrom Mar 3, 2025
Merged
Conversation
- https://arrow.apache.org/docs/python/generated/pyarrow.Table.html#pyarrow.Table.take https://github.com/narwhals-dev/narwhals/blob/dc9fcaa99f179f26b98e81134dd4aab54d1bd462/narwhals/_arrow/typing.py#L19-L24 - https://github.com/narwhals-dev/narwhals/blob/dc9fcaa99f179f26b98e81134dd4aab54d1bd462/narwhals/_arrow/series.py#L388-L398 - https://github.com/narwhals-dev/narwhals/blob/dc9fcaa99f179f26b98e81134dd4aab54d1bd462/narwhals/_arrow/series.py#L412-L416
33 tasks
auto-merge was automatically disabled
March 2, 2025 11:51
Head branch was pushed to by a user without write access
Contributor
Author
|
@zen-xu I've fixed the conflicts - should be good to go wrt #181 (comment) I have noticed some other overlapping overloads - but they were present on
I could fix these in a follow-up? I think they were the source of need all the verbosity here: |
Resolves 2x `pyright` warnings - including as I already touched `min_element_wise`
```log
TypeVar "_ScalarOrArrayT" appears only once in generic function signature
Use "Array[Unknown] | Scalar[Unknown] | ChunkedArray[Unknown]" instead
Pylance (reportInvalidTypeVarUse)
TypeVar "_ScalarT" appears only once in generic function signature
Use "Scalar[Unknown]" instead
Pylance (reportInvalidTypeVarUse)
```
Owner
|
yes，go on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChunkedArray.type#177 (comment)