fix: Preserve generic in ChunkedArray.type#177
Merged
zen-xu merged 1 commit intozen-xu:mainfrom Feb 20, 2025
Merged
Conversation
Discovered during narwhals-dev/narwhals#2007 I worked around this with this, but seemed simple enough to upstream: ```py def _type(self: pa.ChunkedArray[pa.Scalar[_DataType_CoT]]) -> _DataType_CoT: if TYPE_CHECKING: return self[0].type return self.type ```
Contributor
Author
|
Found quite a lot of other things in (narwhals-dev/narwhals#2007) that could help improve I had seen #169, but that |
Contributor
Author
|
@zen-xu do you have a preference on resolving these?
|
dangotbanned
added a commit
to dangotbanned/pyarrow-stubs
that referenced
this pull request
Mar 1, 2025
This was referenced Mar 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered during narwhals-dev/narwhals#2007
I worked around it with this, but seemed simple enough to upstream: