Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unload Vehicle Cargo keybind and context menu action #528

Merged
merged 18 commits into from
Feb 7, 2021

Conversation

ampersand38
Copy link
Member

When merged this pull request will:

  • Add viv cargo unloading functionality to Eject Passengers keybind. In-selection viv cargo will be unloaded from carriers, carriers will have all viv cargo unloaded.

Add viv cargo unloading functionality to Eject Passengers keybind. In-selection viv cargo will be unloaded from carriers, carriers will have all viv cargo unloaded.
@mharis001 mharis001 added the feature Adds a new feature label Jan 24, 2021
@mharis001 mharis001 added this to the 1.10.0 milestone Jan 24, 2021
@mharis001
Copy link
Member

I'd rather see this as a separate keybind instead of part of the eject passengers one.

@ampersand38
Copy link
Member Author

I'd rather see this as a separate keybind instead of part of the eject passengers one.

What about a module and/or a Vehicle Logistics menu item?

@mharis001
Copy link
Member

I think a module isn't convenient and likely overkill for this action. As for a context menu action, I am unsure but I think a keybind provides faster, more convenient access.

@CreepPork
Copy link
Member

A separate keybind would be great, but one with a similar keybind to the eject one. You sometimes would only want to eject the cargo or passengers.

Copy link
Member

@mharis001 mharis001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well. Just some cleanup suggestions.

@mharis001 mharis001 changed the title unload viv cargo Add unload vehicle cargo keybind and context menu action Jan 26, 2021
@mharis001 mharis001 changed the title Add unload vehicle cargo keybind and context menu action Add Unload Vehicle Cargo keybind and context menu action Jan 26, 2021
@mharis001 mharis001 requested a review from CreepPork February 7, 2021 01:23
@neilzar neilzar merged commit efdca89 into zen-mod:master Feb 7, 2021
@ampersand38 ampersand38 deleted the unload-viv-cargo branch February 25, 2021 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants