title_bar: Fix test-support feature mismatch - #62284
Merged
SomeoneToIgnore merged 3 commits intoAug 15, 2026
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
MrSubidubi
changed the title
test-support feature mismatch
RemcoSmitsDev
approved these changes
Aug 15, 2026
SomeoneToIgnore
approved these changes
Aug 15, 2026
SomeoneToIgnore
enabled auto-merge
August 15, 2026 18:50
playdohface
pushed a commit
to playdohface/zed
that referenced
this pull request
Aug 29, 2026
Follow-up to zed-industries#46337, same fix as zed-industries#48280. `title_bar` tests enable `remote/test-support`, which adds `RemoteConnectionOptions::Mock`. But without `recent_projects/test-support`, the match arms for that variant aren't compiled, causing a non-exhaustive match error when testing the crate in isolation: ``` error[E0004]: non-exhaustive patterns: `&RemoteConnectionOptions::Mock(_)` not covered --> crates/remote_connection/src/remote_connection.rs:233:76 ``` CI doesn't catch this because `collab` and `sidebar` enable `recent_projects/test-support` during workspace-wide tests. Adding `remote_connection/test-support` instead isn't enough — that just moves the same error into `recent_projects`. `recent_projects/test-support` covers both. Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #46337, same fix as #48280.
title_bartests enableremote/test-support, which addsRemoteConnectionOptions::Mock. But withoutrecent_projects/test-support, the match arms for that variant aren't compiled, causing a non-exhaustive match error when testing the crate in isolation:CI doesn't catch this because
collabandsidebarenablerecent_projects/test-supportduring workspace-wide tests.Adding
remote_connection/test-supportinstead isn't enough — that just moves the same error intorecent_projects.recent_projects/test-supportcovers both.Release Notes: