remote: Introduce a proper mock remote connection - #46337
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
Veykril
changed the title
Veykril
force-pushed
the
push-luqmopsplumu
branch
3 times, most recently
from
January 8, 2026 08:10
55068ee to
5ed17a8
Compare
Veykril
changed the title
Veykril
force-pushed
the
push-luqmopsplumu
branch
from
January 8, 2026 09:04
e74e95c to
3d018a2
Compare
Veykril
marked this pull request as ready for review
January 8, 2026 09:04
Veykril
enabled auto-merge (squash)
January 8, 2026 09:04
Veykril
force-pushed
the
push-luqmopsplumu
branch
from
January 8, 2026 12:01
3d018a2 to
9265695
Compare
baldwindavid
added a commit
to baldwindavid/zed
that referenced
this pull request
Jan 8, 2026
* main: (349 commits) component_preview: Fix license symlink (zed-industries#46379) Do not react on already observed buffer edits' versions (zed-industries#46308) Fix EP CLI output flicker (zed-industries#46313) vim: Fix bug where repeat operator could lead to unrecoverable replaying state (zed-industries#46376) vim: Implement text-based matching bracket logic for Vim '%' motion to correctly find pairs within comments (zed-industries#45559) Improve LSP button error message (zed-industries#46377) agent: Make reject/accept keybindings consistent with restore/stage (zed-industries#46373) Enable test-support features for some dev dependencies (zed-industries#46370) Capture terminal output when thread is interrupted (zed-industries#46306) Inline assistant tools: no more feature flag (zed-industries#46107) Add `ep split` subcommand for dataset splitting (zed-industries#46364) lsp_button: Fix long LSP version label (zed-industries#46359) remote: Introduce a proper mock remote connection (zed-industries#46337) ep: Allow matching patches against files without trailing newlines (zed-industries#46357) docs: Update "Custom Keybindings for Extension-Based Agents section" to include a troubleshooting note for defining an agent name (zed-industries#46144) Fail early if clangd is downloaded on aarch Linux (zed-industries#46346) ep: Handle errored requests in Anthropic batches (zed-industries#46351) settings_ui: Fix settings search missing results when BM25 finds partial matches (zed-industries#46349) workspace: Unpreview active tab when closing other tabs (zed-industries#46294) terminal: Skip SHLVL when loading login shell environment (zed-industries#46273) ...
rtfeldman
pushed a commit
that referenced
this pull request
Jan 9, 2026
Release Notes: - N/A *or* Added/Fixed/Improved ...
smitbarmase
added a commit
that referenced
this pull request
Feb 3, 2026
Follow-up to #46337 `project_panel` tests enable `remote/test-support` (via `workspace`/`project`), which adds `RemoteConnectionOptions::Mock`. But without `remote_connection/test-support`, the match arm for that variant isn't compiled, causing a non-exhaustive match error when testing the crate in isolation. CI doesn't catch this because `git_ui` happens to enable `remote_connection/test-support` during workspace-wide tests. Release Notes: - N/A
adb-sh
pushed a commit
to adb-sh/zed
that referenced
this pull request
Feb 5, 2026
Follow-up to zed-industries#46337 `project_panel` tests enable `remote/test-support` (via `workspace`/`project`), which adds `RemoteConnectionOptions::Mock`. But without `remote_connection/test-support`, the match arm for that variant isn't compiled, causing a non-exhaustive match error when testing the crate in isolation. CI doesn't catch this because `git_ui` happens to enable `remote_connection/test-support` during workspace-wide tests. Release Notes: - N/A
rtfeldman
pushed a commit
that referenced
this pull request
Feb 5, 2026
Follow-up to #46337 `project_panel` tests enable `remote/test-support` (via `workspace`/`project`), which adds `RemoteConnectionOptions::Mock`. But without `remote_connection/test-support`, the match arm for that variant isn't compiled, causing a non-exhaustive match error when testing the crate in isolation. CI doesn't catch this because `git_ui` happens to enable `remote_connection/test-support` during workspace-wide tests. Release Notes: - N/A
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
Release Notes: - N/A *or* Added/Fixed/Improved ...
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
Follow-up to zed-industries#46337 `project_panel` tests enable `remote/test-support` (via `workspace`/`project`), which adds `RemoteConnectionOptions::Mock`. But without `remote_connection/test-support`, the match arm for that variant isn't compiled, causing a non-exhaustive match error when testing the crate in isolation. CI doesn't catch this because `git_ui` happens to enable `remote_connection/test-support` during workspace-wide tests. Release Notes: - N/A
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
Release Notes: - N/A *or* Added/Fixed/Improved ...
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
Follow-up to zed-industries#46337 `project_panel` tests enable `remote/test-support` (via `workspace`/`project`), which adds `RemoteConnectionOptions::Mock`. But without `remote_connection/test-support`, the match arm for that variant isn't compiled, causing a non-exhaustive match error when testing the crate in isolation. CI doesn't catch this because `git_ui` happens to enable `remote_connection/test-support` during workspace-wide tests. Release Notes: - N/A
ysalitrynskyi
pushed a commit
to ysalitrynskyi/zed
that referenced
this pull request
Aug 15, 2026
Follow-up to zed-industries#46337, same fix as zed-industries#48280. `title_bar` tests enable `remote/test-support`, which adds `RemoteConnectionOptions::Mock`. But without `recent_projects/test-support`, the match arms for that variant aren't compiled, causing a non-exhaustive match error when testing the crate in isolation: ``` error[E0004]: non-exhaustive patterns: `&RemoteConnectionOptions::Mock(_)` not covered --> crates/remote_connection/src/remote_connection.rs:233:76 ``` CI doesn't catch this because `collab` and `sidebar` enable `recent_projects/test-support` during workspace-wide tests. Adding `remote_connection/test-support` instead isn't enough — that just moves the same error into `recent_projects`. `recent_projects/test-support` covers both. Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes: