terminal_view: Fix ghost prompt content when resizing the terminal - #57968
Closed
notJoon wants to merge 2 commits into
Closed
terminal_view: Fix ghost prompt content when resizing the terminal#57968notJoon wants to merge 2 commits into
notJoon wants to merge 2 commits into
Conversation
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
guild
maxdeviant
changed the title
smitbarmase
added
the
area:integrations/terminal
Contributor
|
Thanks for the PR! unfortunately this doesn't seem to have fixed #57879. This PR is on the left in this screenshot. 
|
zelenenka
removed
the
guild
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drag-resizing a standalone terminal left ghost copies of the previous prompt onscreen. The layout snap from #47195 shifted the grid's origin.y by the partial-row slack on every drag pixel, drifting out of phase with alacritty's row scroll and the shell's SIGWINCH repaint.
Drop the per-pixel shift; keep the device-pixel row snap so the original subpixel flicker fix survives. The unused slack now sits as background below the grid, and the grid's screen position stays stable.
Self-Review Checklist:
Closes #57879
Release Notes: