terminal: Reduce flicker on resize - #47195
Merged
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
MrSubidubi
changed the title
pigletfly
force-pushed
the
fix-terminal-blink
branch
from
January 20, 2026 09:33
bc22d66 to
1a78cd0
Compare
Skip PTY resizes for pixel-only changes and coalesce pending resize events. Snap standalone terminal layout to whole device pixels to avoid subpixel jitter. Signed-off-by: pigletfly <wangbing.adam@gmail.com>
pigletfly
force-pushed
the
fix-terminal-blink
branch
from
January 30, 2026 09:51
1a78cd0 to
aed9fc6
Compare
Contributor
|
No clue how hard this would be to implement, though: Why not just "fix" the terminal at the bottom, so the text wouldn't move at all when resizing? |
Collaborator
|
If you could please fix the compile errors, I think this is about ready to merge |
The existing test used `#[test]` and created a `TerminalBuilder` directly. This commit updates the test to use the `#[gpui::test]` attribute and `TestAppContext` to ensure that the test runs within the GPUI executor, which is necessary for correctly handling timers and other async operations within GPUI tests. The `TerminalBuilder` creation is also wrapped in `cx.update` to ensure it's built within the GPUI context.
Contributor
Author
PTAL |
probably-neb
approved these changes
Apr 15, 2026
ebaah46
pushed a commit
to ebaah46/zed
that referenced
this pull request
May 6, 2026
Skip PTY resizes for pixel-only changes and coalesce pending resize events. Snap standalone terminal layout to whole device pixels to avoid subpixel jitter. before: https://github.com/user-attachments/assets/0ad0db83-0099-44c8-b8d1-3dc8146b25ef after: https://github.com/user-attachments/assets/86278014-1c87-4263-a9e5-b58bcc1fa2ea Release Notes: - Fixed: Reduce terminal flicker on resize --------- Signed-off-by: pigletfly <wangbing.adam@gmail.com> Co-authored-by: Ben Kunkle <ben@zed.dev>
kathbigra
pushed a commit
to kathbigra/zed
that referenced
this pull request
May 10, 2026
Skip PTY resizes for pixel-only changes and coalesce pending resize events. Snap standalone terminal layout to whole device pixels to avoid subpixel jitter. before: https://github.com/user-attachments/assets/0ad0db83-0099-44c8-b8d1-3dc8146b25ef after: https://github.com/user-attachments/assets/86278014-1c87-4263-a9e5-b58bcc1fa2ea Release Notes: - Fixed: Reduce terminal flicker on resize --------- Signed-off-by: pigletfly <wangbing.adam@gmail.com> Co-authored-by: Ben Kunkle <ben@zed.dev>
5 tasks
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
Skip PTY resizes for pixel-only changes and coalesce pending resize events. Snap standalone terminal layout to whole device pixels to avoid subpixel jitter. before: https://github.com/user-attachments/assets/0ad0db83-0099-44c8-b8d1-3dc8146b25ef after: https://github.com/user-attachments/assets/86278014-1c87-4263-a9e5-b58bcc1fa2ea Release Notes: - Fixed: Reduce terminal flicker on resize --------- Signed-off-by: pigletfly <wangbing.adam@gmail.com> Co-authored-by: Ben Kunkle <ben@zed.dev>
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
Skip PTY resizes for pixel-only changes and coalesce pending resize events. Snap standalone terminal layout to whole device pixels to avoid subpixel jitter. before: https://github.com/user-attachments/assets/0ad0db83-0099-44c8-b8d1-3dc8146b25ef after: https://github.com/user-attachments/assets/86278014-1c87-4263-a9e5-b58bcc1fa2ea Release Notes: - Fixed: Reduce terminal flicker on resize --------- Signed-off-by: pigletfly <wangbing.adam@gmail.com> Co-authored-by: Ben Kunkle <ben@zed.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip PTY resizes for pixel-only changes and coalesce pending resize events.
Snap standalone terminal layout to whole device pixels to avoid subpixel jitter.
before:
Screen.Recording.2026-01-20.at.16.43.22.mov
after:
Screen.Recording.2026-01-20.at.16.41.43.mov
Release Notes: