Skip to content

Fix various activity indicator issues - #56469

Merged
MrSubidubi merged 1 commit into
mainfrom
activity-icon
May 11, 2026
Merged

Fix various activity indicator issues#56469
MrSubidubi merged 1 commit into
mainfrom
activity-icon

Conversation

@MrSubidubi

Copy link
Copy Markdown
Member

Follow-up to #54791 with some fixes to the activity indicator which resulted in

  • the button no longer being clickable when it should
  • the indicator showing a spinner instead of the proper symbol when downloading or when it should show a warning symbol

Release Notes:

  • Fixed some issues where the activity indicator would show the wrong icon and not be clickable on errors present.

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label May 11, 2026
@zed-community-bot zed-community-bot Bot added the staff Pull requests authored by a current member of Zed staff label May 11, 2026
@MrSubidubi

Copy link
Copy Markdown
Member Author

/cherry-pick preview
/cherry-pick stable

@MrSubidubi
MrSubidubi enabled auto-merge May 11, 2026 20:09
@MrSubidubi
MrSubidubi added this pull request to the merge queue May 11, 2026

@danilo-leal danilo-leal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Merged via the queue into main with commit d35e1cd May 11, 2026
43 checks passed
@MrSubidubi
MrSubidubi deleted the activity-icon branch May 11, 2026 20:21
zed-zippy Bot added a commit that referenced this pull request May 11, 2026
#56471)

Cherry-pick of #56469 to stable

----
Follow-up to #54791 with some fixes to the activity indicator which
resulted in

- the button no longer being clickable when it should
- the indicator showing a spinner instead of the proper symbol when
downloading or when it should show a warning symbol

Release Notes:

- Fixed some issues where the activity indicator would show the wrong
icon and not be clickable on errors present.

Co-authored-by: Finn Evers <finn@zed.dev>
zed-zippy Bot added a commit that referenced this pull request May 11, 2026
…w) (#56470)

Cherry-pick of #56469 to preview

----
Follow-up to #54791 with some fixes to the activity indicator which
resulted in

- the button no longer being clickable when it should
- the indicator showing a spinner instead of the proper symbol when
downloading or when it should show a warning symbol

Release Notes:

- Fixed some issues where the activity indicator would show the wrong
icon and not be clickable on errors present.

Co-authored-by: Finn Evers <finn@zed.dev>
@SomeoneToIgnore

Copy link
Copy Markdown
Contributor

@zed-industries/approved

jonx pushed a commit to jonx/zed-aros that referenced this pull request Jul 17, 2026
Follow-up to zed-industries#54791 with some fixes to the activity indicator which
resulted in

- the button no longer being clickable when it should
- the indicator showing a spinner instead of the proper symbol when
downloading or when it should show a warning symbol

Release Notes:

- Fixed some issues where the activity indicator would show the wrong
icon and not be clickable on errors present.
jolutz pushed a commit to jolutz/zed that referenced this pull request Aug 8, 2026
Follow-up to zed-industries#54791 with some fixes to the activity indicator which
resulted in

- the button no longer being clickable when it should
- the indicator showing a spinner instead of the proper symbol when
downloading or when it should show a warning symbol

Release Notes:

- Fixed some issues where the activity indicator would show the wrong
icon and not be clickable on errors present.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants