Fix when agent-powered merge conflict button shows up - #54791
Merged
Conversation
Collaborator
|
Looks like the activity indicator polish in this PR introduced a regression: the spinner no longer animates. .when(content.icon.is_some(), |this| {
this.start_icon(
Icon::new(IconName::LoadCircle)
.color(Color::Muted)
.size(IconSize::Small),
)
})The previous |
ebaah46
pushed a commit
to ebaah46/zed
that referenced
this pull request
May 6, 2026
…#54791) This PR fixes the logic to dismiss the "resolve merge conflict with agent" button. Previously, we were just observing `merge_heads_by_conflicted_path`, which seems to be intentionally sticky, preserving the conflicted paths until changes are either committed or aborted. This would make the button to resolve conflicts show up even _after_ the changes get resolved. Now, we're checking whether paths are _currently_ conflicted (`is_conflicted()`), and if they are not, we don't display the button, even though the resolution might have not been committed or aborted yet. As a bonus, in this PR, I'm also putting the resolve conflict button _before_ the activity indicator, so as to avoid bounciness, and did a quick polish of the activity indicator button itself, by using the `Button` component. Release Notes: - Fixed a bug with the merge conflict "resolve with agent" button where it would be displayed even though all conflicts have already been resolved.
ebaah46
pushed a commit
to ebaah46/zed
that referenced
this pull request
May 6, 2026
Quick fix for a little regression I introduced in zed-industries#54791 accidentally removing the rotating spinner icon in the activity indicator. Release Notes: - N/A
kathbigra
pushed a commit
to kathbigra/zed
that referenced
this pull request
May 10, 2026
…#54791) This PR fixes the logic to dismiss the "resolve merge conflict with agent" button. Previously, we were just observing `merge_heads_by_conflicted_path`, which seems to be intentionally sticky, preserving the conflicted paths until changes are either committed or aborted. This would make the button to resolve conflicts show up even _after_ the changes get resolved. Now, we're checking whether paths are _currently_ conflicted (`is_conflicted()`), and if they are not, we don't display the button, even though the resolution might have not been committed or aborted yet. As a bonus, in this PR, I'm also putting the resolve conflict button _before_ the activity indicator, so as to avoid bounciness, and did a quick polish of the activity indicator button itself, by using the `Button` component. Release Notes: - Fixed a bug with the merge conflict "resolve with agent" button where it would be displayed even though all conflicts have already been resolved.
kathbigra
pushed a commit
to kathbigra/zed
that referenced
this pull request
May 10, 2026
Quick fix for a little regression I introduced in zed-industries#54791 accidentally removing the rotating spinner icon in the activity indicator. Release Notes: - N/A
This was referenced May 11, 2026
pull Bot
pushed a commit
to esinanturan/zed
that referenced
this pull request
May 11, 2026
Follow-up to zed-industries#54791 with some fixes to the activity indicator which resulted in - the button no longer being clickable when it should - the indicator showing a spinner instead of the proper symbol when downloading or when it should show a warning symbol Release Notes: - Fixed some issues where the activity indicator would show the wrong icon and not be clickable on errors present.
zed-zippy Bot
added a commit
that referenced
this pull request
May 11, 2026
#56471) Cherry-pick of #56469 to stable ---- Follow-up to #54791 with some fixes to the activity indicator which resulted in - the button no longer being clickable when it should - the indicator showing a spinner instead of the proper symbol when downloading or when it should show a warning symbol Release Notes: - Fixed some issues where the activity indicator would show the wrong icon and not be clickable on errors present. Co-authored-by: Finn Evers <finn@zed.dev>
zed-zippy Bot
added a commit
that referenced
this pull request
May 11, 2026
…w) (#56470) Cherry-pick of #56469 to preview ---- Follow-up to #54791 with some fixes to the activity indicator which resulted in - the button no longer being clickable when it should - the indicator showing a spinner instead of the proper symbol when downloading or when it should show a warning symbol Release Notes: - Fixed some issues where the activity indicator would show the wrong icon and not be clickable on errors present. Co-authored-by: Finn Evers <finn@zed.dev>
jasonsmithio
pushed a commit
to paddleboarddev/paddleboard
that referenced
this pull request
May 31, 2026
Quick fix for a little regression I introduced in zed-industries/zed#54791 accidentally removing the rotating spinner icon in the activity indicator. Release Notes: - N/A
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
…#54791) This PR fixes the logic to dismiss the "resolve merge conflict with agent" button. Previously, we were just observing `merge_heads_by_conflicted_path`, which seems to be intentionally sticky, preserving the conflicted paths until changes are either committed or aborted. This would make the button to resolve conflicts show up even _after_ the changes get resolved. Now, we're checking whether paths are _currently_ conflicted (`is_conflicted()`), and if they are not, we don't display the button, even though the resolution might have not been committed or aborted yet. As a bonus, in this PR, I'm also putting the resolve conflict button _before_ the activity indicator, so as to avoid bounciness, and did a quick polish of the activity indicator button itself, by using the `Button` component. Release Notes: - Fixed a bug with the merge conflict "resolve with agent" button where it would be displayed even though all conflicts have already been resolved.
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
Quick fix for a little regression I introduced in zed-industries#54791 accidentally removing the rotating spinner icon in the activity indicator. Release Notes: - N/A
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
Follow-up to zed-industries#54791 with some fixes to the activity indicator which resulted in - the button no longer being clickable when it should - the indicator showing a spinner instead of the proper symbol when downloading or when it should show a warning symbol Release Notes: - Fixed some issues where the activity indicator would show the wrong icon and not be clickable on errors present.
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…#54791) This PR fixes the logic to dismiss the "resolve merge conflict with agent" button. Previously, we were just observing `merge_heads_by_conflicted_path`, which seems to be intentionally sticky, preserving the conflicted paths until changes are either committed or aborted. This would make the button to resolve conflicts show up even _after_ the changes get resolved. Now, we're checking whether paths are _currently_ conflicted (`is_conflicted()`), and if they are not, we don't display the button, even though the resolution might have not been committed or aborted yet. As a bonus, in this PR, I'm also putting the resolve conflict button _before_ the activity indicator, so as to avoid bounciness, and did a quick polish of the activity indicator button itself, by using the `Button` component. Release Notes: - Fixed a bug with the merge conflict "resolve with agent" button where it would be displayed even though all conflicts have already been resolved.
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
Follow-up to zed-industries#54791 with some fixes to the activity indicator which resulted in - the button no longer being clickable when it should - the indicator showing a spinner instead of the proper symbol when downloading or when it should show a warning symbol Release Notes: - Fixed some issues where the activity indicator would show the wrong icon and not be clickable on errors present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the logic to dismiss the "resolve merge conflict with agent" button. Previously, we were just observing
merge_heads_by_conflicted_path, which seems to be intentionally sticky, preserving the conflicted paths until changes are either committed or aborted. This would make the button to resolve conflicts show up even after the changes get resolved. Now, we're checking whether paths are currently conflicted (is_conflicted()), and if they are not, we don't display the button, even though the resolution might have not been committed or aborted yet.As a bonus, in this PR, I'm also putting the resolve conflict button before the activity indicator, so as to avoid bounciness, and did a quick polish of the activity indicator button itself, by using the
Buttoncomponent.Release Notes: