Skip to content

Limit recursive poll file watching - #56345

Closed
karimknaebel wants to merge 1 commit into
zed-industries:mainfrom
karimknaebel:fix-nfs-poll-watcher
Closed

Limit recursive poll file watching#56345
karimknaebel wants to merge 1 commit into
zed-industries:mainfrom
karimknaebel:fix-nfs-poll-watcher

Conversation

@karimknaebel

Copy link
Copy Markdown

Draft PR to highlight a file watcher issue seen on NFS-backed paths.

Zed switches these paths to the polling watcher. The poll watcher can then recurse from the worktree root and repeatedly walk large generated or ignored directories. In my case this kept the Zed server process busy and completely prevented the file tree and search from populating.

The important issue is that recursive polling appears too broad for this filesystem case.

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label May 10, 2026
@zed-community-bot zed-community-bot Bot added the first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions label May 10, 2026
@karimknaebel

Copy link
Copy Markdown
Author

Possibly related:
#54481
#38109

@karimknaebel

Copy link
Copy Markdown
Author

@probably-neb i think this might be related to recent fs watch changes from your side. let me know if i can help you in any way to reproduce this problem :)

@karimknaebel

karimknaebel commented May 12, 2026

Copy link
Copy Markdown
Author

@kubkon tagging you here since you reviewed #54481

the main issue seems to be that recursively watching a large dir with the poll watcher (especially on NFS) completely overwhelms the remote server process to the point where the file tree doesn't populate, search doesn't work, etc.

@ChristopherBiscardi

Copy link
Copy Markdown
Contributor

closing since this never made it out of draft status, and the referenced issues/prs in comments have been merged/closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants