Limit recursive poll file watching - #56345
Closed
karimknaebel wants to merge 1 commit into
Closed
Conversation
5 tasks
Author
Author
|
@probably-neb i think this might be related to recent fs watch changes from your side. let me know if i can help you in any way to reproduce this problem :) |
Author
This was referenced May 19, 2026
Contributor
|
closing since this never made it out of draft status, and the referenced issues/prs in comments have been merged/closed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR to highlight a file watcher issue seen on NFS-backed paths.
Zed switches these paths to the polling watcher. The poll watcher can then recurse from the worktree root and repeatedly walk large generated or ignored directories. In my case this kept the Zed server process busy and completely prevented the file tree and search from populating.
The important issue is that recursive polling appears too broad for this filesystem case.