git: Avoid watching home for missing global config - #56300
Closed
karimknaebel wants to merge 1 commit into
Closed
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @karimknaebel on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
zed-community-bot
Bot
added
the
first contribution
Author
|
@cla-bot check |
cla-bot
Bot
added
the
cla-signed
|
The cla-bot has been summoned, and re-checked this pull request! |
Author
|
Superseeded by #56345 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self-Review Checklist:
I've reviewed my own diff for quality, security, and reliabilityUnsafe blocks (if any) have justifying commentsThe content is consistent with the UI/UX checklistTests cover the new/changed behaviorPerformance impact has been considered and is acceptableImportant
This fix is just a draft fix that codex generated that successfully fixes the "Stuck in 'Starting proxy...'" issue for me. You will probably not want to merge this PR and instead write your own solution for this.
(maybe?) closes #52633
problematic commit: 1afe44c
Summary
Fixes a remote startup hang caused by the global Git config watchers added for unsafe repository handling.
RealFs::watchwatches the nearest existing ancestor when asked to watch a path that does not exist. For~/.gitconfig, that means a user without a global Git config file ends up watching$HOME. On remote filesystems that use the polling watcher, this becomes a recursive poll of the entire home directory, which can keep the remote server busy reading a large home tree while the client is stuck at "Starting proxy...".Release Notes: