Skip to content

extension_api: Add IPv6 support in DAP extensions API - #54984

Merged
tomhoule merged 2 commits into
mainfrom
log-when-dropping-ipv6
Apr 29, 2026
Merged

extension_api: Add IPv6 support in DAP extensions API#54984
tomhoule merged 2 commits into
mainfrom
log-when-dropping-ipv6

Conversation

@tomhoule

Copy link
Copy Markdown
Contributor

Fix forward for #52244

Release Notes:

  • N/A

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Apr 27, 2026
@zed-community-bot zed-community-bot Bot added the staff Pull requests authored by a current member of Zed staff label Apr 27, 2026
@tomhoule
tomhoule marked this pull request as ready for review April 27, 2026 09:36
@tomhoule
tomhoule requested a review from osiewicz April 27, 2026 09:38

@MrSubidubi MrSubidubi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since v0.8.0 is unreleased, do we not want to look into just adding support here perhaps?

@tomhoule

Copy link
Copy Markdown
Contributor Author

Will look into that.

@tomhoule

Copy link
Copy Markdown
Contributor Author

Going with a structured variant for ip-address in the wit. Feedback appreciated (pushing soon).

@tomhoule

Copy link
Copy Markdown
Contributor Author

Pushing current state. Will do a more thorough self review and ping later.

@tomhoule
tomhoule force-pushed the log-when-dropping-ipv6 branch from 4e5c4e4 to bd2ea05 Compare April 27, 2026 11:30
Comment thread crates/extension_host/src/wasm_host/wit/since_v0_6_0.rs
Comment thread crates/extension_api/wit/since_v0.8.0/dap.wit
@maxdeviant maxdeviant changed the title wit: Log on lossy conversion from ipaddr to ipv4 extension_api: Log on lossy conversion from IpAddr to IPv4 Apr 27, 2026
@tomhoule tomhoule changed the title extension_api: Log on lossy conversion from IpAddr to IPv4 extension_api: Add IPv6 support in DAP extensions API Apr 27, 2026
@tomhoule
tomhoule force-pushed the log-when-dropping-ipv6 branch 3 times, most recently from 1a0e470 to 1e09fdc Compare April 27, 2026 14:25
@tomhoule
tomhoule force-pushed the log-when-dropping-ipv6 branch from 1e09fdc to 50a8111 Compare April 27, 2026 14:27
@tomhoule
tomhoule requested a review from MrSubidubi April 27, 2026 14:41
@tomhoule

Copy link
Copy Markdown
Contributor Author

@MrSubidubi I can't merge without the changes requested being resolved

@MrSubidubi MrSubidubi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies!

@tomhoule

Copy link
Copy Markdown
Contributor Author

No worries, thanksyou!

@tomhoule
tomhoule added this pull request to the merge queue Apr 29, 2026
Merged via the queue into main with commit c6c63e8 Apr 29, 2026
31 checks passed
@tomhoule
tomhoule deleted the log-when-dropping-ipv6 branch April 29, 2026 07:29
ebaah46 pushed a commit to ebaah46/zed that referenced this pull request May 6, 2026
jonx pushed a commit to jonx/zed-aros that referenced this pull request Jul 17, 2026
jolutz pushed a commit to jolutz/zed that referenced this pull request Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants