dap: Support IPv6 addresses in TCP transport - #52244
Merged
Merged
Conversation
The entire DAP TCP transport layer was hardcoded to Ipv4Addr, preventing connections to debug adapters on IPv6 hosts. Replace Ipv4Addr with IpAddr and SocketAddrV4 with SocketAddr across the task, dap, dap_adapters, and project crates. The WASM extension API still uses u32 for host (Ipv4Addr bits) to avoid a breaking WIT interface change; IPv4 addresses round-trip through the extension layer as before. Fixes zed-industries#52237
cla-bot
Bot
added
the
cla-signed
zed-codeowner-coordinator
Bot
requested review from
a team,
SomeoneToIgnore and
smitbarmase
and removed request for
a team
March 23, 2026 19:53
zed-community-bot
Bot
added
the
first contribution
zed-codeowner-coordinator
Bot
requested review from
cole-miller and
kubkon
and removed request for
a team
March 23, 2026 19:53
SomeoneToIgnore
removed their request for review
March 30, 2026 12:21
Member
|
Thanks! |
cole-miller
enabled auto-merge (squash)
April 1, 2026 14:23
auto-merge was automatically disabled
April 1, 2026 14:43
Head branch was pushed to by a user without write access
tomhoule
approved these changes
Apr 27, 2026
tomhoule
left a comment
tomhoule
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the contribution!
SomeoneToIgnore
pushed a commit
to polyesterswing/zed
that referenced
this pull request
Apr 29, 2026
…#54984) Fix forward for zed-industries#52244 Release Notes: - N/A
ebaah46
pushed a commit
to ebaah46/zed
that referenced
this pull request
May 6, 2026
The DAP TCP transport layer was hardcoded to `Ipv4Addr`, so IPv6 addresses like `fd00::a` in a debug config's `connect.host` always failed with `hostname must be IPv4: invalid IPv4 address syntax`. Replaced `Ipv4Addr` with `IpAddr` and `SocketAddrV4` with `SocketAddr` across the `task`, `dap`, `dap_adapters`, and `project` crates. The WASM extension API still uses `u32` for the host field to avoid a breaking WIT interface change; IPv4 round-trips through extensions as before. Fixes zed-industries#52237 Release Notes: - Fixed DAP TCP transport rejecting IPv6 addresses when connecting to remote debug adapters. --------- Co-authored-by: moktamd <moktamd@users.noreply.github.com>
ebaah46
pushed a commit
to ebaah46/zed
that referenced
this pull request
May 6, 2026
…#54984) Fix forward for zed-industries#52244 Release Notes: - N/A
kathbigra
pushed a commit
to kathbigra/zed
that referenced
this pull request
May 10, 2026
The DAP TCP transport layer was hardcoded to `Ipv4Addr`, so IPv6 addresses like `fd00::a` in a debug config's `connect.host` always failed with `hostname must be IPv4: invalid IPv4 address syntax`. Replaced `Ipv4Addr` with `IpAddr` and `SocketAddrV4` with `SocketAddr` across the `task`, `dap`, `dap_adapters`, and `project` crates. The WASM extension API still uses `u32` for the host field to avoid a breaking WIT interface change; IPv4 round-trips through extensions as before. Fixes zed-industries#52237 Release Notes: - Fixed DAP TCP transport rejecting IPv6 addresses when connecting to remote debug adapters. --------- Co-authored-by: moktamd <moktamd@users.noreply.github.com>
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
The DAP TCP transport layer was hardcoded to `Ipv4Addr`, so IPv6 addresses like `fd00::a` in a debug config's `connect.host` always failed with `hostname must be IPv4: invalid IPv4 address syntax`. Replaced `Ipv4Addr` with `IpAddr` and `SocketAddrV4` with `SocketAddr` across the `task`, `dap`, `dap_adapters`, and `project` crates. The WASM extension API still uses `u32` for the host field to avoid a breaking WIT interface change; IPv4 round-trips through extensions as before. Fixes zed-industries#52237 Release Notes: - Fixed DAP TCP transport rejecting IPv6 addresses when connecting to remote debug adapters. --------- Co-authored-by: moktamd <moktamd@users.noreply.github.com>
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
…#54984) Fix forward for zed-industries#52244 Release Notes: - N/A
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
The DAP TCP transport layer was hardcoded to `Ipv4Addr`, so IPv6 addresses like `fd00::a` in a debug config's `connect.host` always failed with `hostname must be IPv4: invalid IPv4 address syntax`. Replaced `Ipv4Addr` with `IpAddr` and `SocketAddrV4` with `SocketAddr` across the `task`, `dap`, `dap_adapters`, and `project` crates. The WASM extension API still uses `u32` for the host field to avoid a breaking WIT interface change; IPv4 round-trips through extensions as before. Fixes zed-industries#52237 Release Notes: - Fixed DAP TCP transport rejecting IPv6 addresses when connecting to remote debug adapters. --------- Co-authored-by: moktamd <moktamd@users.noreply.github.com>
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…#54984) Fix forward for zed-industries#52244 Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DAP TCP transport layer was hardcoded to
Ipv4Addr, so IPv6 addresses likefd00::ain a debug config'sconnect.hostalways failed withhostname must be IPv4: invalid IPv4 address syntax.Replaced
Ipv4AddrwithIpAddrandSocketAddrV4withSocketAddracross thetask,dap,dap_adapters, andprojectcrates. The WASM extension API still usesu32for the host field to avoid a breaking WIT interface change; IPv4 round-trips through extensions as before.Fixes #52237
Release Notes: