Skip to content

language_models: Fix is_authenticated state for Cloud provider - #54826

Merged
maxdeviant merged 2 commits into
mainfrom
push-vzozlruozuoz
Apr 27, 2026
Merged

language_models: Fix is_authenticated state for Cloud provider#54826
maxdeviant merged 2 commits into
mainfrom
push-vzozlruozuoz

Conversation

@maxdeviant

Copy link
Copy Markdown
Member

This PR fixes an issue introduced in #54397 where the Zed Cloud provider would not be reflected as "authenticated" if a connection to Collab was attempted, but could not be established.

This was especially noticable when running Zed against a local version of Cloud and not having Collab running.

This restores the original logic prior to that change.

Release Notes:

  • N/A

@maxdeviant maxdeviant self-assigned this Apr 24, 2026
@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Apr 24, 2026
@zed-community-bot zed-community-bot Bot added the staff Pull requests authored by a current member of Zed staff label Apr 24, 2026
@maxdeviant
maxdeviant added this pull request to the merge queue Apr 27, 2026
Merged via the queue into main with commit 2cc960c Apr 27, 2026
31 checks passed
@maxdeviant
maxdeviant deleted the push-vzozlruozuoz branch April 27, 2026 09:02
pull Bot pushed a commit to kp-forks/zed that referenced this pull request May 4, 2026
…s#55325)

Follow up to zed-industries#54826, after which the fallback model would be selected
instead of the cloud model when starting Zed

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Release Notes:

- N/A
ebaah46 pushed a commit to ebaah46/zed that referenced this pull request May 6, 2026
…-industries#54826)

This PR fixes an issue introduced in
zed-industries#54397 where the Zed Cloud
provider would not be reflected as "authenticated" if a connection to
Collab was attempted, but could not be established.

This was especially noticable when running Zed against a local version
of Cloud and not having Collab running.

This restores the original logic prior to that change.

Release Notes:

- N/A
ebaah46 pushed a commit to ebaah46/zed that referenced this pull request May 6, 2026
…s#55325)

Follow up to zed-industries#54826, after which the fallback model would be selected
instead of the cloud model when starting Zed

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Release Notes:

- N/A
kathbigra pushed a commit to kathbigra/zed that referenced this pull request May 10, 2026
…-industries#54826)

This PR fixes an issue introduced in
zed-industries#54397 where the Zed Cloud
provider would not be reflected as "authenticated" if a connection to
Collab was attempted, but could not be established.

This was especially noticable when running Zed against a local version
of Cloud and not having Collab running.

This restores the original logic prior to that change.

Release Notes:

- N/A
jonx pushed a commit to jonx/zed-aros that referenced this pull request Jul 17, 2026
…-industries#54826)

This PR fixes an issue introduced in
zed-industries#54397 where the Zed Cloud
provider would not be reflected as "authenticated" if a connection to
Collab was attempted, but could not be established.

This was especially noticable when running Zed against a local version
of Cloud and not having Collab running.

This restores the original logic prior to that change.

Release Notes:

- N/A
jonx pushed a commit to jonx/zed-aros that referenced this pull request Jul 17, 2026
…s#55325)

Follow up to zed-industries#54826, after which the fallback model would be selected
instead of the cloud model when starting Zed

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Release Notes:

- N/A
jolutz pushed a commit to jolutz/zed that referenced this pull request Aug 8, 2026
…-industries#54826)

This PR fixes an issue introduced in
zed-industries#54397 where the Zed Cloud
provider would not be reflected as "authenticated" if a connection to
Collab was attempted, but could not be established.

This was especially noticable when running Zed against a local version
of Cloud and not having Collab running.

This restores the original logic prior to that change.

Release Notes:

- N/A
jolutz pushed a commit to jolutz/zed that referenced this pull request Aug 8, 2026
…s#55325)

Follow up to zed-industries#54826, after which the fallback model would be selected
instead of the cloud model when starting Zed

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Release Notes:

- N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants