Fix agent default model not picking up after authentication resolve - #54397
Merged
Conversation
Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de> Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
staff
bennetbo
reviewed
Apr 21, 2026
| ); | ||
| }); | ||
|
|
||
| cx.subscribe( |
Member
There was a problem hiding this comment.
We removed this because it causes flickering issues, e.g. if multiple providers authenticate one after another. Instead we only want to update the fallback once after all authenticate tasks completed. And because the Zed provider now actually returns a task we can rely on only calling update_environment_fallback_model once all have authenticated
bennetbo
approved these changes
Apr 21, 2026
bennetbo
changed the title
Member
|
/cherry-pick preview |
bennetbo
enabled auto-merge (squash)
April 21, 2026 10:44
zed-zippy Bot
added a commit
that referenced
this pull request
Apr 21, 2026
…54397) (cherry-pick to preview) (#54399) Cherry-pick of #54397 to preview ---- Regression in #54125 Release Notes: - agent: Fixed an issue where the default Zed model would not get selected after sign-in completed --------- Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de> Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com> Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com> Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de> Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
pull Bot
pushed a commit
to y1024/zed
that referenced
this pull request
Apr 27, 2026
…-industries#54826) This PR fixes an issue introduced in zed-industries#54397 where the Zed Cloud provider would not be reflected as "authenticated" if a connection to Collab was attempted, but could not be established. This was especially noticable when running Zed against a local version of Cloud and not having Collab running. This restores the original logic prior to that change. Release Notes: - N/A
ebaah46
pushed a commit
to ebaah46/zed
that referenced
this pull request
May 6, 2026
…-industries#54826) This PR fixes an issue introduced in zed-industries#54397 where the Zed Cloud provider would not be reflected as "authenticated" if a connection to Collab was attempted, but could not be established. This was especially noticable when running Zed against a local version of Cloud and not having Collab running. This restores the original logic prior to that change. Release Notes: - N/A
kathbigra
pushed a commit
to kathbigra/zed
that referenced
this pull request
May 10, 2026
…ed-industries#54397) Regression in zed-industries#54125 Release Notes: - agent: Fixed an issue where the default Zed model would not get selected after sign-in completed --------- Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de> Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
kathbigra
pushed a commit
to kathbigra/zed
that referenced
this pull request
May 10, 2026
…-industries#54826) This PR fixes an issue introduced in zed-industries#54397 where the Zed Cloud provider would not be reflected as "authenticated" if a connection to Collab was attempted, but could not be established. This was especially noticable when running Zed against a local version of Cloud and not having Collab running. This restores the original logic prior to that change. Release Notes: - N/A
jasonsmithio
pushed a commit
to paddleboarddev/paddleboard
that referenced
this pull request
May 31, 2026
…826) This PR fixes an issue introduced in zed-industries/zed#54397 where the Zed Cloud provider would not be reflected as "authenticated" if a connection to Collab was attempted, but could not be established. This was especially noticable when running Zed against a local version of Cloud and not having Collab running. This restores the original logic prior to that change. Release Notes: - N/A
Zenor27
pushed a commit
to Zenor27/zed
that referenced
this pull request
Jul 4, 2026
…ed-industries#54397) Regression in zed-industries#54125 Release Notes: - agent: Fixed an issue where the default Zed model would not get selected after sign-in completed --------- Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de> Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
…ed-industries#54397) Regression in zed-industries#54125 Release Notes: - agent: Fixed an issue where the default Zed model would not get selected after sign-in completed --------- Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de> Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
…-industries#54826) This PR fixes an issue introduced in zed-industries#54397 where the Zed Cloud provider would not be reflected as "authenticated" if a connection to Collab was attempted, but could not be established. This was especially noticable when running Zed against a local version of Cloud and not having Collab running. This restores the original logic prior to that change. Release Notes: - N/A
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…ed-industries#54397) Regression in zed-industries#54125 Release Notes: - agent: Fixed an issue where the default Zed model would not get selected after sign-in completed --------- Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de> Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression in #54125
Release Notes: