acp: Use new Rust SDK - #52997
Merged
Merged
Conversation
Bridge `SentRequest` results through a oneshot-backed future so ACP requests can be safely awaited from GPUI foreground tasks instead of using `block_task` outside `ConnectionTo::spawn`.
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
staff
Member
Author
|
Waiting on this to merge: #52910 |
Member
Author
|
Will update to official release before merge, but I think it's ready |
benbrandt
marked this pull request as ready for review
April 16, 2026 20:45
bennetbo
approved these changes
Apr 17, 2026
Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
benbrandt
enabled auto-merge (squash)
April 22, 2026 14:47
dennismysh
added a commit
to cerebral-work/dreamcode
that referenced
this pull request
May 3, 2026
The merge in e71fcf8 brought in three upstream API changes that dreamcode-side code didn't track: - acp::* moved into agent_client_protocol::schema (zed-industries#52997). Update reverie_agent's connection/observer/augment/tests to import the alias from the new path. - AgentPanel::create_thread was removed in zed-industries#54774. Switch the Reverie menu handler in agent_ui::agent_panel to the upstream-aligned new_external_agent_thread pattern that the Zed Agent item next to it already uses. - Dreamcode's Agent::server now requires &Entity<Project> + &App. Update the call site in acp_tools::restart_selected_connection to pass the workspace's project handle. Workspace cargo check, dream_inspector + reverie_agent test suites (31/31), and ./script/clippy on the pinned 1.95 toolchain are all green after these changes. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
4 tasks
kathbigra
pushed a commit
to kathbigra/zed
that referenced
this pull request
May 10, 2026
Testing out Niko's new SDK design Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - N/A
Zenor27
pushed a commit
to Zenor27/zed
that referenced
this pull request
Jul 4, 2026
Testing out Niko's new SDK design Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - N/A
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
Testing out Niko's new SDK design Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - N/A
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
Testing out Niko's new SDK design Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing out Niko's new SDK design
Self-Review Checklist:
Release Notes: