Skip to content

Update futures to 0.3.32 - #52910

Merged
dinocosta merged 2 commits into
mainfrom
futures-update
Apr 5, 2026
Merged

dinocosta merged 2 commits into
mainfrom
futures-update

Conversation

@dinocosta

@dinocosta dinocosta commented Apr 1, 2026

Copy link
Copy Markdown
Member

As part of the work that is being developed for the Project Panel's Undo & Redo system, in https://github.com/zed-industries/zed/tree/5039-create-redo , we're implementing an asynchronous task queue which simply receives a message with the operation/change that is meant to be carried out, in order to ensure these run in a sequential fashion.

While trying to use futures_channel::mpsc::Receiver, it was noted that recv method was not available so this Pull Request updates the futures crate to 0.3.32, where it is available.

This version also deprecates try_next in favor of try_recv so this Pull Request updates existing callers of try_next to use try_recv, which was mostly updating the expected return type from Result<Option<T>> to Result<T>.

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Release Notes:

  • N/A

Co-authored-by: Yara <git@yara.blue>
@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Apr 1, 2026
@zed-community-bot zed-community-bot Bot added the staff Pull requests authored by a current member of Zed staff label Apr 1, 2026
@maxdeviant maxdeviant changed the title chore: update futures to 0.3.32 Update futures to 0.3.32 Apr 1, 2026
@dinocosta

Copy link
Copy Markdown
Member Author

@maxdeviant Almost faster than the bot!!!

@benbrandt benbrandt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like this for some ACP reasons :D looks good

@benbrandt benbrandt mentioned this pull request Apr 2, 2026
5 tasks
@dinocosta

Copy link
Copy Markdown
Member Author

I’ve updated this branch with ‎⁠main⁠, so it needs a fresh approval. I had already spoken with @benbrandt, who had already approved these changes, and agreed to merge this today so it can go into the next Nightly. That will give us a bit more time to test before it lands in Preview.

I’ll go ahead and merge now, but please do take another look at the updated changes when you get a chance, @benbrandt. Thanks! 🙇

@dinocosta
dinocosta merged commit c0f01c4 into main Apr 5, 2026
31 checks passed
@dinocosta
dinocosta deleted the futures-update branch April 5, 2026 22:05
rtfeldman pushed a commit that referenced this pull request Apr 5, 2026
As part of the work that is being developed for the Project Panel's Undo
& Redo system, in
https://github.com/zed-industries/zed/tree/5039-create-redo , we're
implementing an asynchronous task queue which simply receives a message
with the operation/change that is meant to be carried out, in order to
ensure these run in a sequential fashion.

While trying to use `futures_channel::mpsc::Receiver`, it was noted that
`recv` method was not available so this Pull Request updates the
`futures` crate to `0.3.32`, where it is available.

This version also deprecates `try_next` in favor of `try_recv` so this
Pull Request updates existing callers of `try_next` to use `try_recv`,
which was mostly updating the expected return type from
`Result<Option<T>>` to `Result<T>`.

Co-authored-by: Yara <git@yara.blue>
piper-of-dawn pushed a commit to piper-of-dawn/zed that referenced this pull request Apr 25, 2026
As part of the work that is being developed for the Project Panel's Undo
& Redo system, in
https://github.com/zed-industries/zed/tree/5039-create-redo , we're
implementing an asynchronous task queue which simply receives a message
with the operation/change that is meant to be carried out, in order to
ensure these run in a sequential fashion.

While trying to use `futures_channel::mpsc::Receiver`, it was noted that
`recv` method was not available so this Pull Request updates the
`futures` crate to `0.3.32`, where it is available.

This version also deprecates `try_next` in favor of `try_recv` so this
Pull Request updates existing callers of `try_next` to use `try_recv`,
which was mostly updating the expected return type from
`Result<Option<T>>` to `Result<T>`.

Co-authored-by: Yara <git@yara.blue>
Zenor27 pushed a commit to Zenor27/zed that referenced this pull request Jul 4, 2026
As part of the work that is being developed for the Project Panel's Undo
& Redo system, in
https://github.com/zed-industries/zed/tree/5039-create-redo , we're
implementing an asynchronous task queue which simply receives a message
with the operation/change that is meant to be carried out, in order to
ensure these run in a sequential fashion.

While trying to use `futures_channel::mpsc::Receiver`, it was noted that
`recv` method was not available so this Pull Request updates the
`futures` crate to `0.3.32`, where it is available.

This version also deprecates `try_next` in favor of `try_recv` so this
Pull Request updates existing callers of `try_next` to use `try_recv`,
which was mostly updating the expected return type from
`Result<Option<T>>` to `Result<T>`.

Co-authored-by: Yara <git@yara.blue>
jonx pushed a commit to jonx/zed-aros that referenced this pull request Jul 17, 2026
As part of the work that is being developed for the Project Panel's Undo
& Redo system, in
https://github.com/zed-industries/zed/tree/5039-create-redo , we're
implementing an asynchronous task queue which simply receives a message
with the operation/change that is meant to be carried out, in order to
ensure these run in a sequential fashion.

While trying to use `futures_channel::mpsc::Receiver`, it was noted that
`recv` method was not available so this Pull Request updates the
`futures` crate to `0.3.32`, where it is available.

This version also deprecates `try_next` in favor of `try_recv` so this
Pull Request updates existing callers of `try_next` to use `try_recv`,
which was mostly updating the expected return type from
`Result<Option<T>>` to `Result<T>`.

Co-authored-by: Yara <git@yara.blue>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants