Skip to content

extensions_ui: Fix duplicated button element IDs preventing uninstall - #47745

Merged
maxdeviant merged 3 commits into
zed-industries:mainfrom
fury0928:fix-extension-uninstall-button-id
Jan 27, 2026
Merged

extensions_ui: Fix duplicated button element IDs preventing uninstall#47745
maxdeviant merged 3 commits into
zed-industries:mainfrom
fury0928:fix-extension-uninstall-button-id

Conversation

@fury0928

@fury0928 fury0928 commented Jan 27, 2026

Copy link
Copy Markdown

Closes #47656

Release Notes:

  • Fixed extension uninstall button not working when an upgrade is available.

@cla-bot

This comment was marked as outdated.

@zed-community-bot zed-community-bot Bot added the first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions label Jan 27, 2026
@fury0928

This comment was marked as outdated.

@MrSubidubi

This comment was marked as outdated.

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Jan 27, 2026
@cla-bot

This comment was marked as outdated.

@MrSubidubi MrSubidubi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find, thank you for looking into this! One comment and we are good to merge.

Comment thread crates/extensions_ui/src/extensions_ui.rs Outdated
@fury0928

Copy link
Copy Markdown
Author

Can you review again for my update?

@fury0928

This comment was marked as spam.

@MrSubidubi

Copy link
Copy Markdown
Member

Please stop pinging employees - we will tale a look once we find the time to do so. Thank you.

@maxdeviant maxdeviant changed the title extensions_ui: Fix duplicate button element IDs preventing uninstall extensions_ui: Fix duplicated button element IDs preventing uninstall Jan 27, 2026

@maxdeviant maxdeviant left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maxdeviant
maxdeviant dismissed MrSubidubi’s stale review January 27, 2026 14:43

This review has been addressed.

@maxdeviant
maxdeviant merged commit 01409a2 into zed-industries:main Jan 27, 2026
28 checks passed
@fury0928

Copy link
Copy Markdown
Author

Thank you for your review

@MrSubidubi

Copy link
Copy Markdown
Member

Also, congratulations to your first contribution! 🎉

benbrandt pushed a commit that referenced this pull request Jan 28, 2026
…#47745)

Closes #47656

Release Notes:

- Fixed extension uninstall button not working when an upgrade is
available.

---------

Co-authored-by: Marshall Bowers <git@maxdeviant.com>
@benbrandt benbrandt mentioned this pull request Jan 28, 2026
benbrandt added a commit that referenced this pull request Jan 28, 2026
- **extensions_ui: Fix duplicated button element IDs preventing
uninstall (#47745)**
- **acp: Add agent server extension deprecation banner (#47817)**
- **acp: Add upsell banner for built-in agents in registry page
(#47853)**

Release Notes:

- Fixed extension uninstall button not working when an upgrade is
available.

---------

Co-authored-by: Dream <42954461+eureka928@users.noreply.github.com>
Co-authored-by: Marshall Bowers <git@maxdeviant.com>
Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
naaiyy added a commit to Glass-HQ/Glass that referenced this pull request Feb 16, 2026
Key changes:
- Reopen with encoding (zed-industries#46553) - new encoding selector with reopen support
- Relative line jumps in go-to-line (zed-industries#46932)
- Terminal tab renaming (zed-industries#45800)
- Project search spinner while search underway (zed-industries#47620)
- Git: retain "since" diffs, avoid unwrap in panel, don't rebuild diff on repo change
- Extensions: fix duplicate button IDs preventing uninstall (zed-industries#47745)
- SendKeystrokes: don't use layout key equivalents (zed-industries#47061)
- Collab tests extracted to integration crate (deleted in our fork)
- Various CI, docs, and agent improvements

Conflict resolutions:
- Kept native_button style, adopted extension_button_id() for unique IDs
- Added encoding_selector::init alongside browser::init
- Fixed _cx → cx rename for new encoding selector render code

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jonx pushed a commit to jonx/zed-aros that referenced this pull request Jul 17, 2026
…zed-industries#47745)

Closes zed-industries#47656

Release Notes:

- Fixed extension uninstall button not working when an upgrade is
available.

---------

Co-authored-by: Marshall Bowers <git@maxdeviant.com>
jolutz pushed a commit to jolutz/zed that referenced this pull request Aug 8, 2026
…zed-industries#47745)

Closes zed-industries#47656

Release Notes:

- Fixed extension uninstall button not working when an upgrade is
available.

---------

Co-authored-by: Marshall Bowers <git@maxdeviant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to uninstall not upgraded extesion

3 participants