Skip to content

project: Add spinner while search is underway - #47620

Merged
danilo-leal merged 2 commits into
zed-industries:mainfrom
zertosh:project_search_indicator
Jan 27, 2026
Merged

project: Add spinner while search is underway#47620
danilo-leal merged 2 commits into
zed-industries:mainfrom
zertosh:project_search_indicator

Conversation

@zertosh

@zertosh zertosh commented Jan 26, 2026

Copy link
Copy Markdown
Contributor

When there are no search results, it's clear that a search is still
ongoing because the landing page says "Searching...". However, once
there's at least one result found, it becomes completely unclear when
search is actually finished. This adds a spinner immediately to the
right of the result counter that stops once the search is finished.

zed-project-search.mp4

Release Notes:

  • Improved project search loading UI.

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Jan 26, 2026
@danilo-leal danilo-leal self-assigned this Jan 26, 2026

@danilo-leal danilo-leal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this one!

@danilo-leal
danilo-leal enabled auto-merge (squash) January 27, 2026 00:18
@danilo-leal
danilo-leal merged commit f601880 into zed-industries:main Jan 27, 2026
28 checks passed
@zertosh
zertosh deleted the project_search_indicator branch January 27, 2026 00:27
naaiyy added a commit to Glass-HQ/Glass that referenced this pull request Feb 16, 2026
Key changes:
- Reopen with encoding (zed-industries#46553) - new encoding selector with reopen support
- Relative line jumps in go-to-line (zed-industries#46932)
- Terminal tab renaming (zed-industries#45800)
- Project search spinner while search underway (zed-industries#47620)
- Git: retain "since" diffs, avoid unwrap in panel, don't rebuild diff on repo change
- Extensions: fix duplicate button IDs preventing uninstall (zed-industries#47745)
- SendKeystrokes: don't use layout key equivalents (zed-industries#47061)
- Collab tests extracted to integration crate (deleted in our fork)
- Various CI, docs, and agent improvements

Conflict resolutions:
- Kept native_button style, adopted extension_button_id() for unique IDs
- Added encoding_selector::init alongside browser::init
- Fixed _cx → cx rename for new encoding selector render code

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jonx pushed a commit to jonx/zed-aros that referenced this pull request Jul 17, 2026
When there are no search results, it's clear that a search is still
ongoing because the landing page says "Searching...". However, once
there's at least one result found, it becomes completely unclear when
search is actually finished. This adds a spinner immediately to the
right of the result counter that stops once the search is finished.


https://github.com/user-attachments/assets/a0ca4e2a-c506-42a4-bc4b-c1eb32d69e79

Release Notes:

- Added spinner to project search, indicating that a search is still
ongoing.

---------

Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
jolutz pushed a commit to jolutz/zed that referenced this pull request Aug 8, 2026
When there are no search results, it's clear that a search is still
ongoing because the landing page says "Searching...". However, once
there's at least one result found, it becomes completely unclear when
search is actually finished. This adds a spinner immediately to the
right of the result counter that stops once the search is finished.


https://github.com/user-attachments/assets/a0ca4e2a-c506-42a4-bc4b-c1eb32d69e79

Release Notes:

- Added spinner to project search, indicating that a search is still
ongoing.

---------

Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants