Skip to content

remote: Wrap uname invocation in sh for nu shell - #40084

Merged
Veykril merged 1 commit into
mainfrom
veykril/push-onulsstlyupy
Oct 14, 2025
Merged

remote: Wrap uname invocation in sh for nu shell#40084
Veykril merged 1 commit into
mainfrom
veykril/push-onulsstlyupy

Conversation

@Veykril

@Veykril Veykril commented Oct 13, 2025

Copy link
Copy Markdown
Member

Closes #39994

Release Notes:

  • Fixed remoting not working when nushell is set as the default shell on the remote target

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Oct 13, 2025
@Veykril
Veykril force-pushed the veykril/push-onulsstlyupy branch from dae2f91 to 79a42ae Compare October 13, 2025 08:59
@Veykril
Veykril force-pushed the veykril/push-onulsstlyupy branch from 79a42ae to 8a9978a Compare October 13, 2025 16:54
@GustavoWidman

GustavoWidman commented Oct 13, 2025

Copy link
Copy Markdown

since we're checking for nushell explicitly, why not use nushell syntax instead of spawning a separate shell, either by doing ^uname -sm (calling external uname) or by doing uname | $"($in.kernel-name) ($in.machine)" for a replacement of uname -sm and either ^uname -m or uname | get machine for uname -m

@Veykril

Veykril commented Oct 13, 2025

Copy link
Copy Markdown
Member Author

Oh that sounds better, thanks!

@Veykril
Veykril force-pushed the veykril/push-onulsstlyupy branch from 8a9978a to 5b7a90a Compare October 14, 2025 06:32
@Veykril
Veykril force-pushed the veykril/push-onulsstlyupy branch from 5b7a90a to 5d03894 Compare October 14, 2025 06:32
@Veykril
Veykril enabled auto-merge (squash) October 14, 2025 06:35
@Veykril
Veykril merged commit 025938b into main Oct 14, 2025
22 checks passed
@Veykril
Veykril deleted the veykril/push-onulsstlyupy branch October 14, 2025 06:51
reflectronic pushed a commit that referenced this pull request Oct 14, 2025
Closes #39994

Release Notes:

- Fixed remoting not working when nushell is set as the default shell on
the remote target
GustavoWidman added a commit to GustavoWidman/nix that referenced this pull request Oct 17, 2025
This reverts commit e2465c5.

nushell has been pached on ssh remotes thanks to
zed-industries/zed#40084. yay!
@mortang2410

mortang2410 commented Oct 29, 2025

Copy link
Copy Markdown

I am on Mac OS and I still see this problem

image

Using Zed 0.210.4 428ef50

Apparently using ^uname did not fix it.

@Veykril

Veykril commented Oct 30, 2025

Copy link
Copy Markdown
Member Author

Thanks for raising this once more, I'll investigate!

@Veykril

Veykril commented Oct 30, 2025

Copy link
Copy Markdown
Member Author

Ah this broke with our quoting changes again it seems

Veykril added a commit that referenced this pull request Nov 3, 2025
#40084 (comment)
Closes #41547

Release Notes:

- Fixed remoting not working when the remote has nu set as its shell
P1n3appl3 pushed a commit to bnjjj/zed that referenced this pull request Nov 4, 2025
zed-industries#40084 (comment)
Closes zed-industries#41547

Release Notes:

- Fixed remoting not working when the remote has nu set as its shell
tomatitito pushed a commit to tomatitito/zed that referenced this pull request Nov 7, 2025
zed-industries#40084 (comment)
Closes zed-industries#41547

Release Notes:

- Fixed remoting not working when the remote has nu set as its shell
jasonsmithio pushed a commit to paddleboarddev/paddleboard that referenced this pull request May 31, 2026
zed-industries/zed#40084 (comment)
Closes zed-industries/zed#41547

Release Notes:

- Fixed remoting not working when the remote has nu set as its shell
jolutz pushed a commit to jolutz/zed that referenced this pull request Aug 8, 2026
…s#40084)

Closes zed-industries#39994

Release Notes:

- Fixed remoting not working when nushell is set as the default shell on
the remote target
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants