Fix regression on SSH remotes not running NuShell - #39994
Closed
GustavoWidman wants to merge 1 commit into
Closed
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @GustavoWidman on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
Author
|
@cla-bot check |
cla-bot
Bot
added
the
cla-signed
|
The cla-bot has been summoned, and re-checked this pull request! |
NuShell does not support `uname -sm`, so invoke `sh -c "uname -sm"` instead which will also work under nushell. See nushell/nushell#12570 for the choice quote: "being posix/bash compliant is a non-goal". This was already patched and merged a few months ago in #25613, which fixed the original issue (#21005) but there seems to have been a regression of sorts, maybe when migrating/refactoring something.
maxdeviant
changed the title
Veykril
added a commit
that referenced
this pull request
Oct 14, 2025
reflectronic
pushed a commit
that referenced
this pull request
Oct 14, 2025
jasonsmithio
pushed a commit
to paddleboarddev/paddleboard
that referenced
this pull request
May 31, 2026
Closes zed-industries/zed#39994 Release Notes: - Fixed remoting not working when nushell is set as the default shell on the remote target
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was already patched and merged a few months ago in #25613, which fixed the original issue (#21005) but there seems to have been a regression of sorts, maybe when migrating/refactoring something.
NuShell does not support
uname -sm, so invokesh -c "uname -sm"instead which will also work under nushell. See nushell/nushell#12570 for the choice quote: "being posix/bash compliant is a non-goal".Release Notes: