Skip to content

project search: Reduce hangs on main thread - #39857

Merged
osiewicz merged 6 commits into
mainfrom
project-search-unchained
Oct 9, 2025
Merged

project search: Reduce hangs on main thread#39857
osiewicz merged 6 commits into
mainfrom
project-search-unchained

Conversation

@osiewicz

@osiewicz osiewicz commented Oct 9, 2025

Copy link
Copy Markdown
Member

This takes the idea that @RemcoSmitsDev started on in #39354. We did away with grabbing a snapshot of the display map when buffer coordinates were sufficient.
Closes #37267

Release Notes:

  • Reduced micro-stutters in project search with large multi-buffer contents.

osiewicz and others added 5 commits October 9, 2025 10:26
This makes it so that we don't need to compute adjusted selections on
each code action refresh request; only those that need it.

Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
prepare_highlight_query_from_selection

Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
used anyways)

Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
own liking

Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Oct 9, 2025
Comment thread crates/editor/src/editor.rs Outdated
Co-authored-by: Remco djsmits12@gmail.com
@osiewicz
osiewicz merged commit ba2337f into main Oct 9, 2025
22 checks passed
@osiewicz
osiewicz deleted the project-search-unchained branch October 9, 2025 11:11
smitbarmase added a commit that referenced this pull request Oct 14, 2025
…ecting (#40168)

Regressed in #39857, only on
Nightly.

Release Notes:

- N/A
Veykril added a commit that referenced this pull request Oct 27, 2025
Fixes a regression introduced in
#39857. As for the exact
reason this causes this issue I am not yet sure will investigate (as per
the todos in code)

Fixes ZED-23R

Release Notes:

- N/A *or* Added/Fixed/Improved ...
Veykril added a commit that referenced this pull request Oct 27, 2025
Fixes a regression introduced in
#39857. As for the exact
reason this causes this issue I am not yet sure will investigate (as per
the todos in code)

Fixes ZED-23R

Release Notes:

- N/A *or* Added/Fixed/Improved ...
Veykril added a commit that referenced this pull request Oct 27, 2025
Fixes a regression introduced in
#39857. As for the exact
reason this causes this issue I am not yet sure will investigate (as per
the todos in code)

Fixes ZED-23R

Release Notes:

- N/A *or* Added/Fixed/Improved ...
xipeng-jin pushed a commit to xipeng-jin/zed that referenced this pull request Oct 31, 2025
…es#41237)

Fixes a regression introduced in
zed-industries#39857. As for the exact
reason this causes this issue I am not yet sure will investigate (as per
the todos in code)

Fixes ZED-23R

Release Notes:

- N/A *or* Added/Fixed/Improved ...
xipeng-jin pushed a commit to xipeng-jin/zed that referenced this pull request Nov 2, 2025
…es#41237)

Fixes a regression introduced in
zed-industries#39857. As for the exact
reason this causes this issue I am not yet sure will investigate (as per
the todos in code)

Fixes ZED-23R

Release Notes:

- N/A *or* Added/Fixed/Improved ...
tomatitito pushed a commit to tomatitito/zed that referenced this pull request Nov 7, 2025
…es#41237)

Fixes a regression introduced in
zed-industries#39857. As for the exact
reason this causes this issue I am not yet sure will investigate (as per
the todos in code)

Fixes ZED-23R

Release Notes:

- N/A *or* Added/Fixed/Improved ...
jasonsmithio pushed a commit to paddleboarddev/paddleboard that referenced this pull request May 31, 2026
…ecting (#40168)

Regressed in zed-industries/zed#39857, only on
Nightly.

Release Notes:

- N/A
jasonsmithio pushed a commit to paddleboarddev/paddleboard that referenced this pull request May 31, 2026
Fixes a regression introduced in
zed-industries/zed#39857. As for the exact
reason this causes this issue I am not yet sure will investigate (as per
the todos in code)

Fixes ZED-23R

Release Notes:

- N/A *or* Added/Fixed/Improved ...
jolutz pushed a commit to jolutz/zed that referenced this pull request Aug 8, 2026
This takes the idea that @RemcoSmitsDev started on in
zed-industries#39354. We did away with
grabbing a snapshot of the display map when buffer coordinates were
sufficient.
Closes zed-industries#37267

Release Notes:

- Reduced micro-stutters in project search with large multi-buffer
contents.

---------

Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Zed freezes / crashes during Project Search

2 participants