Reduce display_map snapshot creation - #39354
Merged
nia-e merged 16 commits intoOct 17, 2025
Merged
Conversation
While I was debugging why the project search was slow I discoverd that we where making in a few cases multiple display_map snapshot within the same function root caller. This also popped up inside my instruments capture.
cla-bot
Bot
added
the
cla-signed
Member
|
@nia-e would you be able to run your perf script on this change? I'm curious how much of a difference it makes. |
osiewicz
added a commit
that referenced
this pull request
Oct 9, 2025
This takes the idea that @RemcoSmitsDev started on in #39354. We did away with grabbing a snapshot of the display map when buffer coordinates were sufficient. Closes #37267 Release Notes: - Reduced micro-stutters in project search with large multi-buffer contents. --------- Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
Contributor
|
Slapped
I'll take the 0.7% as just noise, but clearly this speeds some stuff up so it's worth merging imo |
Collaborator
Author
|
That's great to hear, I will merge main in again tonight, then. Thanks for profiling! |
RemcoSmitsDev
force-pushed
the
reduce-display-snapshot-creation
branch
from
October 17, 2025 15:05
caaaa05 to
eb34d52
Compare
RemcoSmitsDev
force-pushed
the
reduce-display-snapshot-creation
branch
from
October 17, 2025 15:41
eb34d52 to
0eec61f
Compare
Contributor
|
LGTM. Thanks for the PR ^^ |
jasonsmithio
pushed a commit
to paddleboarddev/paddleboard
that referenced
this pull request
May 31, 2026
This takes the idea that @RemcoSmitsDev started on in zed-industries/zed#39354. We did away with grabbing a snapshot of the display map when buffer coordinates were sufficient. Closes #37267 Release Notes: - Reduced micro-stutters in project search with large multi-buffer contents. --------- Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
Re-applies zed-industries#30840 This PR re-applies the initial [PR](zed-industries#30840). As it was closed because it was hard to land, because of the many conflicts. This PR re-applies the changes for it. In several cases we were creating multiple display_map snapshots within the same root-level function call. Creating a display_map snapshot is quite slow, and in some cases we were creating the snapshot multiple times. Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-applies #30840
This PR re-applies the initial PR. As it was closed because it was hard to land, because of the many conflicts. This PR re-applies the changes for it.
I discovered that in several cases we were creating multiple display_map snapshots within the same root-level function call. I noticed that creating a display_map snapshot is quite slow, and found that in some cases we were creating the snapshot multiple times.
cc @ConradIrwin As you reviewed my previous PR.
Release Notes: