Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project_panel: Add precise drag-and-drop for files onto folded directories #22983

Merged

Conversation

0xtimsb
Copy link
Member

@0xtimsb 0xtimsb commented Jan 10, 2025

Closes #19192

  1. Changed the drag overlay of entries for better visibility of where to drop.
  2. Folded directories (except for the last folded one) will be highlighted as drop targets.
  3. The delimiter between folded directories prevents the directory highlight from losing focus and acts as part of the directory to avoid flickering.

This works just like VS Code does.

fold-drop.webm

Release Notes:

  • Added precise drag-and-drop for files onto folded directories in the Project Panel.

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jan 10, 2025
@0xtimsb 0xtimsb force-pushed the fix-moved-items-into-folded-dirs branch from 34075d7 to 184c065 Compare January 10, 2025 21:39
@0xtimsb
Copy link
Member Author

0xtimsb commented Jan 10, 2025

Fixed a small edge case. Sorry for pushing after opening the PR.

@JosephTLyons
Copy link
Collaborator

Fixed a small edge case. Sorry for pushing after opening the PR.

There's no issue with pushing after opening - the team does this frequently. We tend to open PRs very early and just push to them as we work on them.

@JosephTLyons
Copy link
Collaborator

I think this might close this issue as well:

@0xtimsb 0xtimsb force-pushed the fix-moved-items-into-folded-dirs branch from e928e7a to 8ec5aef Compare January 26, 2025 13:14
Copy link
Contributor

@SomeoneToIgnore SomeoneToIgnore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀
Thank you.

@SomeoneToIgnore SomeoneToIgnore self-assigned this Jan 28, 2025
@SomeoneToIgnore SomeoneToIgnore merged commit f314662 into zed-industries:main Jan 28, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot move folder into a collapsed folder
4 participants