zed-editor: 0.165.4 -> 0.166.1

[niklaskorz]

As zed-industries/zed#21550 has finally been merged, we can prepare for one of the next releases making use of the Livekit Rust SDK for macOS and Linux, instead of just the Livekit Swift SDK for macOS.

This PR provides the necessary work to build the Livekit Rust SDK for Zed.

The from-source built of WebRTC itself, which is required by Livekit, has been implemented by @WeetHet, with some feedback and fixes from my side (the commit log reflects this, where I specified @WeetHet as the main author of the WebRTC commit, with me as co-author). Thank you!

Note: Screensharing and audio recording is currently disabled on Linux. This is an upstream limitation that also exists in the official Zed distributions. You can receive audio and screensharings shared by macOS users though.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[bbigras]

v0.166.1 is out.

[jcdickinson]

Smoke tested on NixOS, boots to UI just fine.

[niklaskorz]

macOS is pretty much ready, checking Linux again tomorrow

[jcdickinson]

Did a smoke test with some light editing, but no collaboration. Seems to be working on NixOS unstable.

Thanks for figuring out LiveKit BTW.

[WeetHet]

Did a smoke test with some light editing, but no collaboration. Seems to be working on NixOS unstable.

Thanks for figuring out LiveKit BTW.

I really would love to also have dynamically linked boringssl in the livekit build cause I really don't love statically linking SSL. Probably not in this PR though

[GaetanLepage]

Fails on aarch64-linux: https://paste.glepage.com/raw/sloth-bird-sheep

[GaetanLepage]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 356757

---

x86_64-linux

✅ 2 packages built:

• livekit-libwebrtc
• zed-editor

---

aarch64-linux

❌ 2 packages failed to build:

• livekit-libwebrtc
• zed-editor

---

x86_64-darwin

✅ 2 packages built:

• livekit-libwebrtc
• zed-editor

---

aarch64-darwin

✅ 2 packages built:

• livekit-libwebrtc
• zed-editor

[niklaskorz]

aarch64-linux

❌ 2 packages failed to build:

* livekit-libwebrtc

* zed-editor

Oh interesting, I'll try to figure out what's going wrong there.

Edit: aarch64-linux-gnu-gcc: not found sounds like WebRTC is expecting some kind of cross compiler when targeting aarch64 instead of just using gcc

Edit 2: Fortunately that appears to be a problem that was solved in the Chromium package already, where they have this patch:

nixpkgs/pkgs/applications/networking/browsers/chromium/common.nix

Lines 638 to 642 in d3c42f1

	lib.optionalString (stdenv.hostPlatform == stdenv.buildPlatform && stdenv.hostPlatform.isAarch64)
	''
	substituteInPlace build/toolchain/linux/BUILD.gn \
	--replace 'toolprefix = "aarch64-linux-gnu-"' 'toolprefix = ""'
	''

[GaetanLepage]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 356757

---

x86_64-linux

✅ 2 packages built:

• livekit-libwebrtc
• zed-editor

---

aarch64-linux

✅ 2 packages built:

• livekit-libwebrtc
• zed-editor

---

x86_64-darwin

✅ 2 packages built:

• livekit-libwebrtc
• zed-editor

---

aarch64-darwin

✅ 2 packages built:

• livekit-libwebrtc
• zed-editor

[GaetanLepage]

Looks good !

[niklaskorz]

Overall I think this is ready. There are some more improvements that could be done to the updateScript of livekit-webrtc (currently it works directly on the branch name while it should fetch the latest commit rev of the m114 branch instead and pass that to gclient2nix), and I'm also not entirely sure about the version = "m114"; (should it be version = "114-unstable-2024-06-05"; instead? WebRTC does not have tagged versions).

I also again want to emphasize the amount of work @WeetHet contributed, without who this would not have been possible. :)

[GaetanLepage]

Overall I think this is ready. There are some more improvements that could be done to the updateScript of livekit-webrtc (currently it works directly on the branch name while it should fetch the latest commit rev of the m114 branch instead and pass that to gclient2nix), and I'm also not entirely sure about the version = "m114"; (should it be version = "114-unstable-2024-06-05"; instead? WebRTC does not have tagged versions).

I also again want to emphasize the amount of work @WeetHet contributed, without who this would not have been possible. :)

Well done guys !

[GaetanLepage]

LGTM

[GaetanLepage]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 356757

---

x86_64-linux

✅ 2 packages built:

• livekit-libwebrtc
• zed-editor

---

aarch64-linux

✅ 2 packages built:

• livekit-libwebrtc
• zed-editor

---

x86_64-darwin

✅ 2 packages built:

• livekit-libwebrtc
• zed-editor

---

aarch64-darwin

✅ 2 packages built:

• livekit-libwebrtc
• zed-editor