-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest CI build very slow to open some docset #532
Comments
I've tested the latest builds (as below) so far on bintray and the issue is still there.
|
Does it also wait if there are no docsets installed?
|
I'm sorry I didn't get your question. The problem is when click on fontawesome(and some other docsets) entry on the left of main window, the window will freeze for a few seconds. It will eventually recover but when switch back from other docset to fa it happens again. When no docsets installed there is no such way to test. |
Oh, I see. I didn't re-read the original message before to replying to your today's one. I bet the problem is with Qt WebKit. I'll try to prepare a build with the new Qt WebKit, so we could see if the problem will go away. Not sure how log it will take. |
Do you mind put Windows build instructions in Wiki? So I can build zeal agains Qt 5.6.x and new Qt Webkit and test. |
The new Qt WebKit requires MSVC. Zeal should build with VS 2015, but I haven't tried that yet. I'll update the wiki once have something to put there. The basic instruction is to compile libarchive, and then use Qt Creator or qmake directly to build Zeal. |
I've found out that commit 23aac1a is the cause of this issue by using git bisect. Since commit 23aac1a is about allowing online resource access, I've tested v0.3.0 with network disconnected. No more problem, fontawesome docset opens quickly. It seems fontawesome docset links to online resources while for some reason Zeal opens them slowly (probably due to network connectivity) in a blocking way, thus freezes the main window. Maybe a offline mode that behaves in the old offline way can be helpful. |
Thanks for hunting this down! It's quite strange that network connectivity
has such effects. And apparently it's a rare Windows-only bug.
Let's first check whether the problem persists with the new Qt WebKit. If
so, then I'll think how to block or allow networking as a per docset basis.
|
I'm trying to compile Zeal against Qt 5.7.0 & new Qt WebKit TP4. But I got below error in QtCreator. I already have libarchive built and the archive_static.lib file placed in the .lib directory of Zeal build directory. Before I put libarchive in .lib the error message was about unable to find file archive_static.lib.
|
Updated to 0.3.0 and all of the searches take forever, previous version was fast. |
@Kraml you need libarchive. @RenaldasK What exactly takes forever - search itself or opening a page? This issue is about a slowdown during when a page is loaded. |
@trollixx have you read my feedback? |
@Kraml I need to improve my comprehension skills :) I assume you built libarchive with the same compliler, so perhaps MSVC requires some additional flags, not sure. Most likely URLs without scheme cause this issue. Zeal accesses files via I think I have a quick fix, checking it out... |
Yes I've built libarchive on the same machine with the same MSVC compiler I used to built Zeal. All following the instructions from libarchive official wiki. This machine is a clean Win7 VM with no other software but MSVC 2015 installed. When building Zeal + libarchive with msys2/mingw on my regular laptop Win10 I have no such problem. However as the new Qt Webkit requires MSVC to build I cannot try it with msys2. On the other hand I've built Qt 5.7.0 with its bundled Webkit(released in a separate src package) by msys2 and compiled Zeal against it. Building process went fine, but the problem persists. |
This change adds back a custom network access manager, that was removed as a fix for zealdocs#474. Although this time the URL validation logic is much more simple.
@Kraml, could you give this change a try? |
This change adds back a custom network access manager, that was removed as a fix for zealdocs#474. Although this time the URL validation logic is much more simple.
Yes it fixed the problem. |
Great! I'll prepare 0.3.1 shortly. Only one more regression to fix (#604). |
Thanks. |
Any chance of getting a new installer to download from the website? That would be much appreciated. |
@Kraml FYI, we are working on MinGW support in new QtWebKit, it already builds in a branch. All necessary changes will be included into the next release, and there will be binaries produced in Qt CI. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
When trying the latest CI build (zeal-unstable-0.2.1-146-gac2225b) I found that when click on some docsets the zeal window just freeze for a long time, probably 20 seconds or longer. At the end it still opens the doc. If switch to another to another doc and back, it has high chance to still freeze for a long time.
I noticed at least docker and font awesome doc have the issue. There is no such problem in 0.2.1. I've redownloaded the two docsets but it is still the same.
The text was updated successfully, but these errors were encountered: