Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow access to online resources #474

Closed
trollixx opened this issue Jan 18, 2016 · 1 comment
Closed

Allow access to online resources #474

trollixx opened this issue Jan 18, 2016 · 1 comment
Labels
scope/ui/webview status/done type/feature
Milestone
0.3.0

Comments

@trollixx
Copy link
Member

Currently Zeal is forced into 'Offline Mode' simply by rejecting any requests to non-local resources. I don't see a reason why this mode shouldn't be configurable.

There is a pretty good use case for allowing Zeal access remote servers.

An Offline Mode option in the File menu similarly to major browsers would be handy, when one actually wants to forbid any online access.
@trollixx trollixx added this to the 0.3.0 milestone Jan 18, 2016
trollixx added a commit to trollixx/zeal that referenced this issue Oct 9, 2016
@trollixx
core: Reject no-scheme URLs on a local file system (fixes zealdocs#532)
e358e84 
This change adds back a custom network access manager, that was removed
as a fix for zealdocs#474. Although this time the URL validation logic is much
more simple.
trollixx added a commit to trollixx/zeal that referenced this issue Oct 9, 2016
@trollixx
core: Reject no-scheme URLs on a local file system (fixes zealdocs#532)
4861f92 
This change adds back a custom network access manager, that was removed
as a fix for zealdocs#474. Although this time the URL validation logic is much
more simple.
@trollixx trollixx mentioned this issue Oct 9, 2016
Merged
trollixx added a commit that referenced this issue Oct 9, 2016
@trollixx
core: Reject no-scheme URLs on a local file system (fixes #532) (#620)
caff862 
This change adds back a custom network access manager, that was removed
as a fix for #474. Although this time URL validation is much more simple.
@lock
Copy link

lock bot commented Sep 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for a related request.

@lock lock bot locked and limited conversation to collaborators Sep 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
scope/ui/webview status/done type/feature
Milestone
0.3.0
Development

No branches or pull requests
1 participant
@trollixx