[ZIP 32] Add registered child key derivation with support for tags#978
Merged
Conversation
nuttycom
approved these changes
Feb 12, 2025
daira
force-pushed
the
add-child-key-with-tag
branch
2 times, most recently
from
ab3b159 to
e973ec9
Compare
daira
changed the title
daira
changed the title
daira
force-pushed
the
add-child-key-with-tag
branch
2 times, most recently
from
515f1ed to
167da77
Compare
daira
changed the title
daira
force-pushed
the
add-child-key-with-tag
branch
from
167da77 to
ef54363
Compare
nuttycom
previously requested changes
Feb 13, 2025
Contributor
nuttycom
left a comment
nuttycom
left a comment
There was a problem hiding this comment.
Clarifying the type and meaning of full_width_leaf is blocking.
daira
force-pushed
the
add-child-key-with-tag
branch
3 times, most recently
from
92a0ffb to
36b09c4
Compare
daira
force-pushed
the
add-child-key-with-tag
branch
2 times, most recently
from
993a280 to
14ea5d9
Compare
str4d
requested changes
Feb 17, 2025
Collaborator
str4d
left a comment
str4d
left a comment
There was a problem hiding this comment.
Reviewed 14ea5d99e7f05de8b46fa819eaec82847f19cbc0
daira
commented
Feb 17, 2025
daira
commented
Feb 17, 2025
daira
force-pushed
the
add-child-key-with-tag
branch
from
133771e to
a1cbf65
Compare
str4d
approved these changes
Feb 17, 2025
Collaborator
str4d
left a comment
str4d
left a comment
There was a problem hiding this comment.
ACK a1cbf65ffc1853fe23b2871727fa6d6cda7fafdb
This was referenced Feb 17, 2025
nuttycom
reviewed
Feb 19, 2025
nuttycom
changed the title
daira
force-pushed
the
add-child-key-with-tag
branch
2 times, most recently
from
4deb4c4 to
ced99d4
Compare
requirement to document the usage in a ZIP. Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
… the LaTeX cases environment. Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Co-authored-by: Jack Grigg <thestr4d@gmail.com>
daira
force-pushed
the
add-child-key-with-tag
branch
from
ced99d4 to
f81f700
Compare
…tion. Co-authored-by: Jack Grigg <jack@electriccoin.co> Co-authored-by: Kris Nuttycombe <kris@nutty.land> Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
daira
force-pushed
the
add-child-key-with-tag
branch
from
f81f700 to
e601318
Compare
Collaborator
Author
|
This is ready for re-review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.