Support tagged ZIP 32 child derivation for registered application protocols#24
Merged
Merged
Conversation
daira
force-pushed
the
support-tagged-child-derivation
branch
from
cdd24c0 to
402a3e4
Compare
daira
changed the title
zip32
daira
force-pushed
the
support-tagged-child-derivation
branch
from
402a3e4 to
3999336
Compare
daira
commented
Feb 13, 2025
daira
force-pushed
the
support-tagged-child-derivation
branch
3 times, most recently
from
c788e52 to
7b12eaf
Compare
…ified in a ZIP. Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
daira
force-pushed
the
support-tagged-child-derivation
branch
from
7b12eaf to
c7442d7
Compare
daira
commented
Feb 17, 2025
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
daira
force-pushed
the
support-tagged-child-derivation
branch
from
04b84b3 to
e5b4ea2
Compare
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
This was referenced Feb 18, 2025
daira
commented
Feb 18, 2025
daira
force-pushed
the
support-tagged-child-derivation
branch
5 times, most recently
from
21d9e79 to
3003f3f
Compare
daira
commented
Feb 20, 2025
daira
force-pushed
the
support-tagged-child-derivation
branch
from
011bf64 to
8ba2e44
Compare
str4d
previously requested changes
Feb 20, 2025
daira
force-pushed
the
support-tagged-child-derivation
branch
from
8ba2e44 to
6bc0ab6
Compare
daira
force-pushed
the
support-tagged-child-derivation
branch
from
6bc0ab6 to
23e0fb3
Compare
Contributor
Author
|
Ready for re-review. |
daira
force-pushed
the
support-tagged-child-derivation
branch
from
23e0fb3 to
354834f
Compare
nuttycom
requested changes
Feb 20, 2025
nuttycom
approved these changes
Feb 20, 2025
`registered::SecretKey::{derive_child, derive_child_cryptovalue}`.
Co-authored-by: Jack Grigg <jack@electriccoin.co>
Co-authored-by: Kris Nuttycombe <kris@nutty.land>
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Co-authored-by: Kris Nuttycombe <kris@nutty.land> Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
daira
force-pushed
the
support-tagged-child-derivation
branch
from
fb73395 to
2c177cb
Compare
nuttycom
approved these changes
Feb 20, 2025
Contributor
|
I have verified that the test vectors were correctly imported from zcash/zcash-test-vectors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the specification in zcash/zips#978 .