Skip to content

Bring in latest compact_formats.proto#440

Merged
LarryRuane merged 1 commit intomasterfrom
compactblock-metadata
Jul 4, 2023
Merged

Bring in latest compact_formats.proto#440
LarryRuane merged 1 commit intomasterfrom
compactblock-metadata

Conversation

@str4d
Copy link
Copy Markdown
Contributor

@str4d str4d commented Jul 3, 2023

From zcash/librustzcash@c13c8c6, including the rework of how the commitment tree sizes are to be represented in CompactBlocks.

Please ensure this checklist is followed for any pull requests for this repo. This checklist must be checked by both the PR creator and by anyone who reviews the PR.

  • Relevant documentation for this PR has to be completed before the PR can be merged
  • A test plan for the PR must be documented in the PR notes and included in the test plan for the next regular release

As a note, all CI tests need to be passing and all appropriate code reviews need to be done before this PR can be merged

@str4d
Copy link
Copy Markdown
Contributor Author

str4d commented Jul 3, 2023

Currently a draft because I want zcash/librustzcash#831 to merge before this (so I can ensure I'm referencing the correct commit).

@LarryRuane
Copy link
Copy Markdown
Collaborator

LGTM, @nick-ecc asked me to create a lightwalletd release, but I assume that should wait for this to merge?

@str4d str4d force-pushed the compactblock-metadata branch from 84a79e3 to 6a2fb81 Compare July 4, 2023 03:34
@str4d str4d marked this pull request as ready for review July 4, 2023 03:35
@str4d
Copy link
Copy Markdown
Contributor Author

str4d commented Jul 4, 2023

@LarryRuane I've pulled in the last update from zcash/librustzcash#831; this PR can be reviewed and merged now, and then the release cut.

From zcash/librustzcash@c13c8c6,
including the rework of how the commitment tree sizes are to be
represented in CompactBlocks.
@LarryRuane LarryRuane force-pushed the compactblock-metadata branch from 6a2fb81 to 75c98a3 Compare July 4, 2023 16:55
@LarryRuane
Copy link
Copy Markdown
Collaborator

Testing turned up one problem, force-pushed the fix. With protobuf, if a message (struct) contains another message, the former points to an instance of the latter, rather than being inline. This pointer, within CompactBlock to ChainMetadata was not being initialized, so lightwalletd crashed with a segfault when trying to populate ChainMetadata in common.go: getBlockFromRPC().

@LarryRuane LarryRuane merged commit f0e4c27 into master Jul 4, 2023
@LarryRuane LarryRuane deleted the compactblock-metadata branch July 4, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants