Bring in latest compact_formats.proto#440
Conversation
|
Currently a draft because I want zcash/librustzcash#831 to merge before this (so I can ensure I'm referencing the correct commit). |
|
LGTM, @nick-ecc asked me to create a lightwalletd release, but I assume that should wait for this to merge? |
84a79e3 to
6a2fb81
Compare
|
@LarryRuane I've pulled in the last update from zcash/librustzcash#831; this PR can be reviewed and merged now, and then the release cut. |
From zcash/librustzcash@c13c8c6, including the rework of how the commitment tree sizes are to be represented in CompactBlocks.
6a2fb81 to
75c98a3
Compare
|
Testing turned up one problem, force-pushed the fix. With protobuf, if a message (struct) contains another message, the former points to an instance of the latter, rather than being inline. This pointer, within |
From zcash/librustzcash@c13c8c6, including the rework of how the commitment tree sizes are to be represented in CompactBlocks.
Please ensure this checklist is followed for any pull requests for this repo. This checklist must be checked by both the PR creator and by anyone who reviews the PR.
As a note, all CI tests need to be passing and all appropriate code reviews need to be done before this PR can be merged