Expose API for merkle hash by ebfull · Pull Request #3 · zcash/librustzcash

ebfull · 2018-04-12T03:48:22Z

No description provided.

…sh invocation.

str4d · 2018-04-12T11:56:32Z

+    /// Initializes some parameters for sapling-crypto,
+    /// returning a pointer to the parameters. You should
+    /// free this when you're done with 
+    /// `librustzcash_init_params()`.


librustzcash_free_params

str4d · 2018-04-12T12:00:29Z

+    ).into_xy().0.into_repr();
+
+    // Should be okay, caller is responsible for ensuring the pointer
+    // is valid.


is a valid pointer to 32 bytes.

str4d · 2018-04-12T12:04:20Z

+    }
+
+    let tmp = pedersen_hash::<Bls12, _>(
+        Personalization::MerkleTree(depth),


What happens if a depth larger than 62 is passed in? Relatedly, how do panics unroll into the C++ code - as segfaults?

If a depth larger than 62 is passed in, undefined behavior. Probably a segfault.

Could we add a panic!() if the provided depth is larger than 62?

The code this calls will panic if the depth is larger then 62.

ebfull · 2018-04-12T21:37:45Z

I configured it to abort the process on panics, rather than causing chaos downstream over the FFI boundary. Also enabled link-time optimizations so the static lib is smaller.

… parameters around.

str4d · 2018-04-13T00:48:20Z

+
+lazy_static! {
+    static ref JUBJUB: JubjubBls12 = {
+        JubjubBls12::new()


Just to confirm, this is only the Jubjub parameters? The Sapling and Sprout CRSs will be loaded/unloaded via pointers? Or will the Sapling CRS be similarly statically-loaded?

@ebfull and I discussed this. The Sapling and Sprout CRSs will be loaded via an API through which zcashd passes the paths to the params. Both verification keys along with the Sapling proving key will be loaded into memory immediately, while the Sprout proving key will be loaded and unloaded on-demand.

str4d

utACK.

str4d · 2018-04-15T01:28:39Z

@daira ACKed zcash/zcash#3169 which includes this.

Fq inverse (addition chain for fq)

Part of #3.

ZIP-225/244 #3: Create separate bundles for each part of the transaction.

…14868de..d978256a2 d978256a2 Merge pull request #1 from zcash/compact_tx_transparent 7eeb82e7c Merge pull request #4 from zcash/add_changelog a95359dc9 Apply suggestions from code review 592b637a8 Add transparent data to the `CompactBlock` format. 9d1fb2c41 Add a CHANGELOG.md that documents the evolution of the light client protocol. 180717dfa Merge pull request #3 from zcash/merge_librustzcash_history 450bd4181 Merge the history of the .proto files from `librustzcash` for complete history preservation. a4859d11d Move protobuf files into place for use in `zcash/lightwallet-protocol` 2e66cdd9e Update zcash_client_backend/proto/service.proto eda012519 fix comment f838d10ad Add gRPC LightdInfo Donation Address db12c0415 Merge pull request #1473 from nuttycom/wallet/enrichment_queue 698feba96 Apply suggestions from code review 20ce57ab3 zcash_client_backend: Add `block_height` argument to `decrypt_and_store_transaction` a6dea1da8 Merge pull request #1482 from zancas/doc_tweak 4d2d45fc9 fix incorrect doc-comment e826f4740 update CompactBlock doc-comment, to cover non-Sapling shielded notes, and addresses e9a6c00bf Various documentation improvements 988bc7214 Merge pull request #872 from nuttycom/feature/pre_dag_sync-suggest_scan_ranges 58d07d469 Implement `suggest_scan_ranges` and `update_chain_tip` a9222b338 Address comments from code review. e20310857 Rename proto::compact::{BlockMetadata => ChainMetadata} ac63418c5 Reorganize Sapling and Orchard note commitment tree sizes in CompactBlock. 0fdca14f1 zcash_client_backend: Add note commitment tree sizes to `CompactBlock` serialization. 2a0c2b8b7 zcash_client_backend: Add gRPC bindings behind feature flag 1342f0480 zcash_client_backend: Address compact_formats.proto comments 68aa4e01b zcash_client_backend: Bring in latest `compact_formats.proto` e712eb1bc Add prevHash field to CompactBlock 440384c3e Build protobufs for compact formats git-subtree-dir: zcash_client_backend/lightwallet-protocol git-subtree-split: d978256a2bf33bb5f83846d8994e7377512f5f05

…14868de..23f0768ea 23f0768ea Release lightwallet-protocol v0.4.0 41156c767 Merge pull request #11 from zcash/feature/get_mempool_tx_pools 7c130e883 Add `lightwalletProtocolVersion` field to `LightdInfo` struct. edbb726d7 Apply suggestion from code review 38fddd73b Apply suggestions from code review 0250f2720 Add pool type filtering to `GetMempoolTx` argument. 54ccaadd5 Change semantics of pool-based pruning of compact transactions from "may prune" to "must prune". b0667ec99 Merge pull request #9 from zcash/2025-11-doc-TransparentAddressBlockFilter f3fea7bd4 doc: TransparentAddressBlockFilter doesn't include mempool a67dd323a Merge pull request #8 from zcash/2025-11-lightdinfo-upgrade-info 11da4b7e3 add next upgrade info to LightdInfo structure (GetLightdInfo) 42cd8f720 Transparent data docs update (#7) c0cf957ac Merge pull request #5 from zcash/2025-11-comments 912fc3609 Minor clarification in GetBlockRange documentation. 6b03f2cce Documentation (comments) only d978256a2 Merge pull request #1 from zcash/compact_tx_transparent 7eeb82e7c Merge pull request #4 from zcash/add_changelog a95359dc9 Apply suggestions from code review 592b637a8 Add transparent data to the `CompactBlock` format. 9d1fb2c41 Add a CHANGELOG.md that documents the evolution of the light client protocol. 180717dfa Merge pull request #3 from zcash/merge_librustzcash_history 450bd4181 Merge the history of the .proto files from `librustzcash` for complete history preservation. a4859d11d Move protobuf files into place for use in `zcash/lightwallet-protocol` 2e66cdd9e Update zcash_client_backend/proto/service.proto eda012519 fix comment f838d10ad Add gRPC LightdInfo Donation Address db12c0415 Merge pull request #1473 from nuttycom/wallet/enrichment_queue 698feba96 Apply suggestions from code review 20ce57ab3 zcash_client_backend: Add `block_height` argument to `decrypt_and_store_transaction` a6dea1da8 Merge pull request #1482 from zancas/doc_tweak 4d2d45fc9 fix incorrect doc-comment e826f4740 update CompactBlock doc-comment, to cover non-Sapling shielded notes, and addresses e9a6c00bf Various documentation improvements 988bc7214 Merge pull request #872 from nuttycom/feature/pre_dag_sync-suggest_scan_ranges 58d07d469 Implement `suggest_scan_ranges` and `update_chain_tip` a9222b338 Address comments from code review. e20310857 Rename proto::compact::{BlockMetadata => ChainMetadata} ac63418c5 Reorganize Sapling and Orchard note commitment tree sizes in CompactBlock. 0fdca14f1 zcash_client_backend: Add note commitment tree sizes to `CompactBlock` serialization. 2a0c2b8b7 zcash_client_backend: Add gRPC bindings behind feature flag 1342f0480 zcash_client_backend: Address compact_formats.proto comments 68aa4e01b zcash_client_backend: Bring in latest `compact_formats.proto` e712eb1bc Add prevHash field to CompactBlock 440384c3e Build protobufs for compact formats git-subtree-dir: zcash_client_backend/lightwallet-protocol git-subtree-split: 23f0768ea4471b63285f3c0e9b6fbb361674aa2b

Expose API for init/free of parameters and, to test, a merkle tree ha…

f1d3570

…sh invocation.

str4d reviewed Apr 12, 2018

View reviewed changes

str4d mentioned this pull request Apr 12, 2018

Create a new params global for Sapling zcash/zcash#3053

Closed

ebfull mentioned this pull request Apr 12, 2018

Import sapling global parameters zcash/zcash#3169

Merged

ebfull added 2 commits April 12, 2018 15:01

Fix typos

96654ee

Make panic abort to avoid FFI problems.

cb8c9eb

Use lazy_static to initialize the Jubjub parameters, to avoid passing…

37f20fb

… parameters around.

str4d reviewed Apr 13, 2018

View reviewed changes

ebfull changed the title ~~Expose API for init/free of parameters~~ Expose API for merkle hash Apr 13, 2018

str4d approved these changes Apr 15, 2018

View reviewed changes

str4d requested review from daira and gtank and removed request for daira and gtank April 15, 2018 01:06

str4d merged commit 2a86c91 into zcash:master Apr 15, 2018

str4d referenced this pull request in str4d/librustzcash Aug 28, 2018

Random encoding/decoding tests for PrimeFieldRepr. Closes #3.

176c77d

ebfull added a commit to ebfull/librustzcash that referenced this pull request Feb 23, 2019

Merge pull request zcash#3 from Eirik0/fq-inverse

09e786e

Fq inverse (addition chain for fq)

str4d added a commit that referenced this pull request Feb 26, 2019

Place ff_derive re-exports behind a feature

69ce66a

Part of #3.

swasilyev added a commit to paritytech/librustzcash that referenced this pull request Mar 20, 2020

pairings from the check zcash#3 batched using small exponent test

e00839b

str4d added a commit that referenced this pull request Jun 4, 2021

Merge pull request #392 from nuttycom/feature/zip-225-bundles

4c4d226

ZIP-225/244 #3: Create separate bundles for each part of the transaction.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Expose API for merkle hash#3

Expose API for merkle hash#3
str4d merged 4 commits into
zcash:masterfrom
ebfull:params-and-merkle-hash

ebfull commented Apr 12, 2018 •

edited

Loading

Uh oh!

str4d Apr 12, 2018

Uh oh!

str4d Apr 12, 2018

Uh oh!

str4d Apr 12, 2018

Uh oh!

ebfull Apr 12, 2018

Uh oh!

str4d Apr 12, 2018

Uh oh!

ebfull Apr 13, 2018

Uh oh!

ebfull commented Apr 12, 2018

Uh oh!

str4d Apr 13, 2018

Uh oh!

str4d Apr 15, 2018 •

edited

Loading

Uh oh!

str4d left a comment

Uh oh!

str4d commented Apr 15, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ebfull commented Apr 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

str4d Apr 12, 2018

Choose a reason for hiding this comment

Uh oh!

str4d Apr 12, 2018

Choose a reason for hiding this comment

Uh oh!

str4d Apr 12, 2018

Choose a reason for hiding this comment

Uh oh!

ebfull Apr 12, 2018

Choose a reason for hiding this comment

Uh oh!

str4d Apr 12, 2018

Choose a reason for hiding this comment

Uh oh!

ebfull Apr 13, 2018

Choose a reason for hiding this comment

Uh oh!

ebfull commented Apr 12, 2018

Uh oh!

str4d Apr 13, 2018

Choose a reason for hiding this comment

Uh oh!

str4d Apr 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

str4d left a comment

Choose a reason for hiding this comment

Uh oh!

str4d commented Apr 15, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ebfull commented Apr 12, 2018 •

edited

Loading

str4d Apr 15, 2018 •

edited

Loading