Skip to content

zcash_keys: Fix missing std feature dependencies. #2093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nuttycom merged 2 commits into from
Jan 10, 2026
Merged

zcash_keys: Fix missing std feature dependencies. #2093

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f93ca0
`zcash_keys`: Fix missing `std` feature dependencies.
nuttycom Dec 17, 2025
2f4ae00
Minor improvement to `std` transitivity CHANGELOG message.
nuttycom Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ equihash = { version = "0.2", path = "components/equihash", default-features = f
zcash_address = { version = "0.10", path = "components/zcash_address", default-features = false }
zcash_client_backend = { version = "0.21", path = "zcash_client_backend" }
zcash_encoding = { version = "0.3", path = "components/zcash_encoding", default-features = false }
zcash_keys = { version = "0.12", path = "zcash_keys" }
zcash_keys = { version = "0.12", path = "zcash_keys", default-features = false }

@nuttycom nuttycom Dec 18, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is perhaps not strictly required because none of the crates downstream of zcash_keys in this workspace have no_std builds available, but I think it's useful to do anyway because it's better for std to be visibly and explicitly enabled.

zcash_protocol = { version = "0.7.2", path = "components/zcash_protocol", default-features = false }
zip321 = { version = "0.6", path = "components/zip321" }

Expand Down
2 changes: 1 addition & 1 deletion zcash_client_backend/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ rustdoc-args = ["--cfg", "docsrs"]
[dependencies]
zcash_address.workspace = true
zcash_encoding.workspace = true
zcash_keys = { workspace = true, features = ["sapling"] }
zcash_keys = { workspace = true, features = ["std", "sapling"] }
zcash_note_encryption.workspace = true
zcash_primitives = { workspace = true, features = ["std", "circuits"] }
zcash_protocol.workspace = true
Expand Down
2 changes: 2 additions & 0 deletions zcash_keys/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ workspace.
### Changed
- MSRV is now 1.85.1.
- Migrated to `orchard 0.12`, `sapling-crypto 0.6`.
- The `std` feature flag now enables the equivalent flag on the dependencies
`orchard`, `sapling-crypto`, `zcash_transparent`, and `zcash_address`.

## [0.12.0] - 2025-10-13

Expand Down
16 changes: 12 additions & 4 deletions zcash_keys/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,17 +89,25 @@ zcash_script.workspace = true

[features]
default = ["std"]
std = ["dep:document-features"]
std = [
"dep:document-features",
"orchard?/std",
"sapling?/std",
"transparent/std",
"zcash_address/std",
]

## Enables use of transparent key parts and addresses
transparent-inputs = [
"dep:bip32",
"transparent/transparent-inputs",
"dep:bip32",
"transparent/transparent-inputs",
]

## Enables use of zcashd-derived secp256k1 secret key encodings.
transparent-key-encoding = [
"transparent-inputs", "dep:secp256k1", "dep:zeroize"
"transparent-inputs",
"dep:secp256k1",
"dep:zeroize",
]

## Enables use of Orchard key parts and addresses
Expand Down
Loading