zcash_keys: Fix missing std feature dependencies.#2093
Merged
Conversation
`zcash_keys/std` now implies `orchard?/std`, `sapling?/std`, `transparent/std`, and `zcash_address/std`. In addition, downstream crates of `zcash_keys` within this workspace now must explicitly enable `zcash_keys/std` if its features are required.
nuttycom
commented
Dec 18, 2025
| zcash_client_backend = { version = "0.21", path = "zcash_client_backend" } | ||
| zcash_encoding = { version = "0.3", path = "components/zcash_encoding", default-features = false } | ||
| zcash_keys = { version = "0.12", path = "zcash_keys" } | ||
| zcash_keys = { version = "0.12", path = "zcash_keys", default-features = false } |
Collaborator
Author
There was a problem hiding this comment.
This change is perhaps not strictly required because none of the crates downstream of zcash_keys in this workspace have no_std builds available, but I think it's useful to do anyway because it's better for std to be visibly and explicitly enabled.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2093 +/- ##
==========================================
- Coverage 73.84% 73.83% -0.02%
==========================================
Files 222 222
Lines 36704 36716 +12
==========================================
+ Hits 27103 27108 +5
- Misses 9601 9608 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Jack Grigg <jack@electriccoin.co>
str4d
approved these changes
Jan 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zcash_keys/stdnow impliesorchard?/std,sapling?/std,transparent/std, andzcash_address/std. In addition, downstream crates ofzcash_keyswithin this workspace now must explicitly enablezcash_keys/stdif its features are required.