zcash_address: Add Converter trait and ZcashAddress::convert_with#1791
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## zcash_address-0.6.x #1791 +/- ##
=======================================================
- Coverage 52.97% 52.45% -0.53%
=======================================================
Files 173 173
Lines 21046 21251 +205
=======================================================
- Hits 11149 11147 -2
- Misses 9897 10104 +207 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nuttycom
force-pushed
the
address_converter
branch
3 times, most recently
from
c05d4db to
b1d04cb
Compare
str4d
requested changes
May 7, 2025
This adds a trait that permits contextual conversions from `ZcashAddress` into a target type. Where `TryFromAddress` permits context-less conversions, this trait allows implementers to inspect the contents of an address in the context of other data or operations.
nuttycom
force-pushed
the
address_converter
branch
from
b1d04cb to
456e83e
Compare
str4d
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.