zcash_extensions: Fix build errors following value changes to zcash_protocol#1683
Merged
1 commit merged intoJan 29, 2025
Merged
zcash_extensions: Fix build errors following value changes to zcash_protocol#16831 commit merged into
zcash_protocol#16831 commit merged into
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1683 +/- ##
=======================================
Coverage 51.89% 51.90%
=======================================
Files 180 180
Lines 21169 21167 -2
=======================================
Hits 10986 10986
+ Misses 10183 10181 -2 ☔ View full report in Codecov by Sentry. |
e14b9aa to
b236665
Compare
…protocol` This fixes a few errors that have been introduced over time since `zcash_extensions` is not regularly built, and migrates `zcash_extensions` to eliminate the use of deprecated `zcash_primitives` APIs.
b236665 to
b823aa3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a few errors that have been introduced over time since
zcash_extensionsis not regularly built, and migrateszcash_extensionsto eliminate the use of deprecatedzcash_primitivesAPIs.